Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Install header files #844
This PR make nest install its header files into
For this purpose I modified:
With the headers installed and travis-ci installation into
I tested with cmake 2.8.12, 3.5.1 (ubuntu 16.04) and 3.9.4 (OS X). On the ubuntu system I encountered unrelated compilation issues with gsl and fixed them with 2411f5e. I also tested building and loading
referenced this pull request
Oct 30, 2017
Thanks Tammo, the changes work great.
One small, tenuously related issue that might be able to be bundled together with these changes is that when building NEST inside a Python 3 virtual env, the help files don't build because they aren't Python 3 compatible. Do you know where in the make files this is specified and whether the command could be explicitly changed to call
Hi @tclose ,
Have a look at https://github.com/nest/nest-simulator/blob/master/doc/CMakeLists.txt#L26 .
Nice work, I made a few comments and have a few questions.
Regarding the python 2/3 problem, I think that another PR is indeed necessary to make the files Py3 compatible.
Okay, no worries. A separate PR for building the help pages makes sense. Although I just managed to build NEST in a Python 3 virtualenv on a different machine so I am wondering whether the error I was seeing was due to something strange in my setup (it looked very much like a Python 2/3 error though). Checking that the build is Python 3 compatible is probably a good idea in any case though.