Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow rectangular and box masks to be rotated #845
This PR adds the optional parameters
This have led to some changes in the
The functions check to see if we have rotation as much as possible, so that we can use
I have also added a test.
changed the title from
Allow rectangle and box masks to be rotated
Allow rectangular and box masks to be rotated
Oct 25, 2017
Thank you for this, it looks good. As far as I can see, there are just some minor things to fix, see below.
Looks quite fine, but see comments. We should discuss once more about the "eps" that we are adding, just wondering if we are digging some future grave. For 3D, we olny have two angles. Which rotation possibility are we missing?
@heplesser thank you for your review! I have tried to address your comments, please take a look.
I changed the "eps" to be constant
When it comes to the rotation angles, we are missing rotation from the y-axis to the z-axis (the γ here ). Do you want me to add it? We do not have it for the elliptical mask, but I could add it there as well and make a PR of course.