Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow rectangular and box masks to be rotated #845
This PR adds the optional parameters
This have led to some changes in the
The functions check to see if we have rotation as much as possible, so that we can use
I have also added a test.
heplesser left a comment
Looks quite fine, but see comments. We should discuss once more about the "eps" that we are adding, just wondering if we are digging some future grave. For 3D, we olny have two angles. Which rotation possibility are we missing?
position is pre-calculated in constructor, added some const, eps no longer calculated from length, but just a constant, small number.
@heplesser thank you for your review! I have tried to address your comments, please take a look.
I changed the "eps" to be constant
When it comes to the rotation angles, we are missing rotation from the y-axis to the z-axis (the γ here ). Do you want me to add it? We do not have it for the elliptical mask, but I could add it there as well and make a PR of course.