New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aeif psc delta 2 continued #849

Merged
merged 11 commits into from Nov 28, 2017

Conversation

Projects
None yet
5 participants
@stinebuu
Contributor

stinebuu commented Oct 31, 2017

This is a continuation of PR #613, and can replace that PR. Most of the work has been reviewed, the difference is that with_refr_input_ is defaulted to false and is made set/getable as requested. I have also reordered the placement of with_refr_input_ in aeif_psc_delta.h to get rid of a warning.

Almost all the work is done @lepmik.

@stinebuu stinebuu referenced this pull request Oct 31, 2017

Closed

Aeif psc delta 2 #613

@heplesser heplesser requested review from Silmathoron and heplesser Nov 6, 2017

@Silmathoron

Good work, just a question about possible use of defaultdict to make it lighter and (maybe) easier to understand, otherwise it's all fine!

Show outdated Hide outdated pynest/nest/tests/test_aeif_lsodar.py
Show outdated Hide outdated pynest/nest/tests/test_aeif_lsodar.py
@stinebuu

This comment has been minimized.

Show comment
Hide comment
@stinebuu

stinebuu Nov 27, 2017

Contributor

Sorry I took so long to address your comments, @Silmathoron!

Contributor

stinebuu commented Nov 27, 2017

Sorry I took so long to address your comments, @Silmathoron!

@Silmathoron

Ok 👍
(the question of the docstrings was to be answered by @gtrensch but I guess this is fine ^^)

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Nov 28, 2017

Contributor

@lepmik @stinebuu Thanks for your efforts, merging!

Contributor

heplesser commented Nov 28, 2017

@lepmik @stinebuu Thanks for your efforts, merging!

@heplesser heplesser merged commit 7d59720 into nest:master Nov 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stinebuu stinebuu deleted the stinebuu:lepmik-aeif_psc_delta2 branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment