Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a few typos in documentation comments #855

Merged
merged 4 commits into from Nov 30, 2017
Merged

Conversation

@aserenko
Copy link
Contributor

@aserenko aserenko commented Nov 9, 2017

post-syapic -> postsynaptic,
neruons -> neurons,
is achieve -> is achieved.

aserenko added 2 commits Nov 9, 2017
post-syapic -> postsynaptic,
neruons -> neurons,
is achieve -> is achieved.
Conflicts:
	models/iaf_neuron.h

Resolve merge conflict caused by iaf_neuron model removal
Copy link
Collaborator

@jessica-mitchell jessica-mitchell left a comment

The ipynb filenames are still not completely correct. Could you please change IAF_Neurons_Singularity.ipynb to IAF_neurons_singularity.ipynb. Thanks.

aserenko added 2 commits Nov 29, 2017
IAF_Neurons_Singularity.ipynb -> IAF_neurons_singularity.ipynb,
because this is how it is named there in doc/model_details.
The variable TauR in comments about refractory period is changed
to how the corresponding refractory variables are named in the code.
Also, leed -> lead, and a comma added before "defining" in
"A time object r is constructed defining representation", because
it is r what is defining, not the construction.
@aserenko
Copy link
Contributor Author

@aserenko aserenko commented Nov 29, 2017

A few more changes, even less significant (involving comments that are mostly non-documenting), are added; let them be in the same request.

Copy link
Collaborator

@jessica-mitchell jessica-mitchell left a comment

Looks good, thanks

@heplesser
Copy link
Contributor

@heplesser heplesser commented Nov 30, 2017

Merging after single review as it this PR just concerns typos in documentation.

@heplesser heplesser merged commit a77e4a8 into nest:master Nov 30, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.