Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved structure of secondary event types #856

Merged
merged 1 commit into from Feb 6, 2018
Merged

Conversation

@janhahne
Copy link

@janhahne janhahne commented Nov 13, 2017

This PR removes a lot of redundant code from event.h. Previously the classes GapJunctionEvent, DelayedRateConnectionEvent, InstantaneousRateConnectionEvent and DiffusionConnectionEvent all contained a lot of identical code, which is now moved to a general template base class DataSecondaryEvent< typename D, typename E >. One template typename specifies the data type that is stored, the second is used to distinguish different classes which use the same data type in order to have seperate static variables for all derived classes

Copy link
Contributor

@hakonsbm hakonsbm left a comment

Thanks for this! It all looks good to me.

@jougs
jougs approved these changes Feb 6, 2018
Copy link
Contributor

@jougs jougs left a comment

Thanks for the cleanup. Approving and merging

@jougs jougs merged commit 9d665a5 into nest:master Feb 6, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@janhahne janhahne deleted the janhahne:improve_events branch Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.