Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_disconnect by converting filter object to list for len #864

Merged
merged 1 commit into from Dec 6, 2017

Conversation

@jakobj
Copy link
Contributor

@jakobj jakobj commented Dec 6, 2017

This test fails for Python 3 if filter objects are not converted to lists before calling len.

I suggest @jougs as reviewer

Copy link
Contributor

@tammoippen tammoippen left a comment

Typical Python2/3 issue. 👍 .

@heplesser
Copy link
Contributor

@heplesser heplesser commented Dec 6, 2017

Trivial fix to test, merging without further review.

@heplesser heplesser merged commit 3d4d2ba into nest:master Dec 6, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jakobj jakobj deleted the jakobj:fix/test_disconnect branch Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.