Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue error message when attempting to set an invalid resolution #888

Merged
merged 2 commits into from Mar 7, 2018

Conversation

Projects
None yet
5 participants
@hakonsbm
Copy link
Contributor

hakonsbm commented Jan 31, 2018

Issues an error message when attempting to change the resolution to something which is not a multiple of the tic size.

Fixes #643.

@Silmathoron
Copy link
Contributor

Silmathoron left a comment

Change in cpp looks fine.
Regarding the sli test, wouldn't it be better to also check when it is not supposed to fail? Or is it already tested elsewhere?

@hakonsbm

This comment has been minimized.

Copy link
Contributor Author

hakonsbm commented Mar 7, 2018

@Silmathoron The idea of the test is to check that you get an error message when trying to set an invalid resolution. Setting the resolution to a valid value is already in multiple other tests.

@Silmathoron
Copy link
Contributor

Silmathoron left a comment

Ok, all good then!

@stinebuu
Copy link
Contributor

stinebuu left a comment

This looks good to me.

@heplesser heplesser merged commit cf94e96 into nest:master Mar 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hakonsbm hakonsbm deleted the hakonsbm:invalid_resolution branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.