New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check target #906

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@heplesser
Contributor

heplesser commented Mar 8, 2018

This PR removes the check target for now, because its existence easily misleads users (see recent discussion on NEST User mailing list).

@heplesser heplesser added this to the NEST 2.16 milestone Mar 8, 2018

@heplesser heplesser requested review from tammoippen and terhorstd Mar 8, 2018

@jougs jougs requested review from jougs and removed request for tammoippen Mar 13, 2018

@jougs

jougs approved these changes Mar 13, 2018

Thanks for taking care of this. I'll merge without second review, as this is a minor change that seems to prevent problems easily without the potential to break anything.

@jougs jougs merged commit d3d8630 into nest:master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@heplesser heplesser deleted the heplesser:remove-check-target branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment