New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat and clean up Name definitions #909

Merged
merged 13 commits into from Mar 19, 2018

Conversation

Projects
None yet
3 participants
@jougs
Contributor

jougs commented Mar 12, 2018

This PR removes the (mostly wrong and useless) comments from the headers that define Name objects, cleans up inconsistent definitions/declarations and removes unused Names.

It also adds a regression test to check consistent definition/declaration and also that all Names defined are actually used.

jougs added some commits Mar 12, 2018

Add regression test to test for consistent use of Names
This tests if the definitions and declaration of const Names are
consistent and that all names defined are actually used.

@jougs jougs referenced this pull request Mar 12, 2018

Merged

Erfc neuron model #492

@jougs jougs requested a review from heplesser Mar 12, 2018

@jougs jougs added this to the NEST 2.16 milestone Mar 12, 2018

@jougs jougs changed the title from reformat names header to Reformat and clean up Name definitions Mar 12, 2018

@heplesser

@jougs Thanks for working on this! I added some suggestions concerning details of the python code for the test.

I am uncertain about dropping all the comments. Maybe imprecise and outdated comments (and quite a number are) are worse than no comments; and with a decent IDE you can quickly check where a name is used. Should be discuss this for a final decision at the next NEST ODVC?

@heplesser heplesser requested a review from terhorstd Mar 14, 2018

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Mar 19, 2018

Contributor

The Open NEST Developer Meeting on 19 March has no objections to removing the comments from the Names files.

Contributor

heplesser commented Mar 19, 2018

The Open NEST Developer Meeting on 19 March has no objections to removing the comments from the Names files.

@heplesser heplesser requested review from stinebuu and removed request for terhorstd Mar 19, 2018

@stinebuu

Excellent work! I don't have any complaints.

@heplesser heplesser merged commit 6ccfa02 into nest:master Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment