Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue in help #928

Merged
merged 3 commits into from Apr 20, 2018
Merged

Fixed issue in help #928

merged 3 commits into from Apr 20, 2018

Conversation

@babsey
Copy link
Contributor

@babsey babsey commented Apr 16, 2018

This PR fixed the issue in help function. The PR #913 was not clean.
The function load_help returned one or two variables which is bad.

@heplesser heplesser requested review from heplesser and jougs Apr 16, 2018
Copy link
Contributor

@heplesser heplesser left a comment

@babsey There seems to be a small PEP8 problem (some line is too long), otherwise it seems fine.

Copy link
Contributor

@jougs jougs left a comment

Thanks for catching the uncleanliness! Other than my minor comment (which really already should have been in the review of #913) I like this change. If my comment is addressed I will approve and merge.

The documentation of the object.
string:
Filename for the object
Filepath of the help object.
"""

helpdir = os.path.join(os.environ['NEST_INSTALL_DIR'], "share", "doc",

This comment has been minimized.

@jougs

jougs Apr 17, 2018
Contributor

Sorry for not having caught this earlier, but please replace this line by

    helpdir = os.path.join(nest.sli_func("statusdict/prgdocdir ::"), "help")

This is IMO cleaner and does not rely on any environment variables being set.

@jougs
jougs approved these changes Apr 20, 2018
Copy link
Contributor

@jougs jougs left a comment

Thanks for the changes.

@heplesser heplesser merged commit e38d0c7 into nest:master Apr 20, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@babsey babsey deleted the babsey:Fixed_help branch Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.