New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue in help #928

Merged
merged 3 commits into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@babsey
Contributor

babsey commented Apr 16, 2018

This PR fixed the issue in help function. The PR #913 was not clean.
The function load_help returned one or two variables which is bad.

@heplesser heplesser requested review from heplesser and jougs Apr 16, 2018

@heplesser

@babsey There seems to be a small PEP8 problem (some line is too long), otherwise it seems fine.

@jougs

Thanks for catching the uncleanliness! Other than my minor comment (which really already should have been in the review of #913) I like this change. If my comment is addressed I will approve and merge.

Show outdated Hide outdated pynest/nest/lib/hl_api_helper.py
@jougs

jougs approved these changes Apr 20, 2018

Thanks for the changes.

@heplesser heplesser merged commit e38d0c7 into nest:master Apr 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@babsey babsey deleted the babsey:Fixed_help branch Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment