Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added test for spatial kernels in topology (depends on #823). #929
Great to have a test for the kernels, that is certainly needed! This looks mostly good, however I do wonder if the plotting really should be included. I do see the need for it if new kernels are included, but the test file is already quite long, the
SpacialTester class is in particular long, and at least as far as I am aware, we usually reserve plotting etc for examples and not for tests?
added a commit
this pull request
Apr 18, 2018
@stinebuu I have restructured and simplified the code. I decided to keep the plotting in for now (but split it out into a separate subclass), since code placement would otherwise have become a bit problematic when supporting a test without plotting and an example with plotting. I have also merged all recent changes from master, so #823 with the gamma kernel is now included.
Thank you for asking me to review it.
Some technical points concerning me are:
@babsey I have now also explicitly added as a reviewer, so you get a nice "Submit review" button with "comment/require changes/approve" radio buttons to click :).
I will push in a little while.