New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obtain help pager information via SLI and handle failures better #948

Merged
merged 4 commits into from Jun 4, 2018

Conversation

@heplesser
Contributor

heplesser commented May 2, 2018

This is a replacement for #931, see also discussion there. We now get pager information directly from the SLI interpreter if available. Error handling is also more robust; in the past, if the pager did not work, help would simply do nothing.

@physicalist Could you also review this one?

heplesser added some commits May 2, 2018

Get information about pager from SLI.
Systematically search for pager if none defined, with cat as last resort.
Provide error message if pager fails.
@steffengraber

Looks good and works for me.

Show outdated Hide outdated pynest/nest/lib/hl_api_helper.py
Show outdated Hide outdated pynest/nest/lib/hl_api_helper.py
@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser May 4, 2018

Contributor

@physicalist Thank you for your suggestions, I had overlooked those cases. They are integrated now, together with a bit of restructuring.

Contributor

heplesser commented May 4, 2018

@physicalist Thank you for your suggestions, I had overlooked those cases. They are integrated now, together with a bit of restructuring.

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser May 14, 2018

Contributor

@physicalist Could you check if you are happy with my changes and approve the PR if you are?

Contributor

heplesser commented May 14, 2018

@physicalist Could you check if you are happy with my changes and approve the PR if you are?

@heplesser heplesser requested review from gtrensch and removed request for Silmathoron May 28, 2018

@gtrensch

Looks good to me!

@heplesser heplesser merged commit 4a99001 into nest:master Jun 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@heplesser heplesser deleted the heplesser:fix-help-pager-nestrc branch Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment