New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #954: Avoid the use of unrelated typenames to distinguish template classes #956

Merged
merged 2 commits into from May 14, 2018

Conversation

Projects
None yet
4 participants
@janhahne
Contributor

janhahne commented May 13, 2018

This PR fixes #954 by using the derived class itself as distinguishing template type.
@heplesser and @jakobj could you please have a look?

@jakobj

jakobj approved these changes May 13, 2018

Nice ,that was quick! Maybe use DataType instead of Data for first template, otherwise I am happy! 👍

@jougs

jougs approved these changes May 14, 2018

Thanks!

@jougs jougs merged commit 603090f into nest:master May 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@janhahne janhahne deleted the janhahne:fix954 branch May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment