Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #954: Avoid the use of unrelated typenames to distinguish template classes #956

Merged
merged 2 commits into from May 14, 2018

Conversation

@janhahne
Copy link

@janhahne janhahne commented May 13, 2018

This PR fixes #954 by using the derived class itself as distinguishing template type.
@heplesser and @jakobj could you please have a look?

@jakobj
jakobj approved these changes May 13, 2018
Copy link
Contributor

@jakobj jakobj left a comment

Nice ,that was quick! Maybe use DataType instead of Data for first template, otherwise I am happy! 👍

Jan Hahne
@jougs
jougs approved these changes May 14, 2018
Copy link
Contributor

@jougs jougs left a comment

Thanks!

@jougs jougs merged commit 603090f into nest:master May 14, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@janhahne janhahne deleted the janhahne:fix954 branch May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.