Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve documentation on setting extent and center (addresses #961) #962
Added paragraphs to sections on setting extent and center use of values that are exact binary numbers to avoid roundoff.
Addresses #961, which cannot be fixed in a perfect and general way: there is simply no general way in which we can avoid rounding errors here (at least not one that would be relatively straightforward to implement), and NEST needs to terminate if rounding errors would need to inconsistent placement of nodes in the Topology-internal data structures.
Just a question for clarification, do the 'components' refer to the '2-element tuple of floats' mentioned in the preceding paragraph?
I suggest on line 279 that 'Also' be removed as I don't think it adds much to the sentence (if you want to keep it, please add a comma after it).
There is a comma splice in that sentence too; please either put a full stop or semicolon after fractions, and make "see Sec . . ." a complete sentence or put it in parentheses.