New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #825: Improve sign check #966

Merged
merged 2 commits into from Jun 11, 2018

Conversation

Projects
None yet
3 participants
@sanjayankur31
Contributor

sanjayankur31 commented Jun 6, 2018

Fixes #825

@sanjayankur31

This comment has been minimized.

Show comment
Hide comment
@sanjayankur31

sanjayankur31 Jun 6, 2018

Contributor

Eh - I seem to have broken a whole lot of tests with this. Checking up.

Contributor

sanjayankur31 commented Jun 6, 2018

Eh - I seem to have broken a whole lot of tests with this. Checking up.

@sanjayankur31 sanjayankur31 changed the title from Improve sign check to Fix #825: Improve sign check Jun 6, 2018

@heplesser heplesser requested review from heplesser and jougs Jun 11, 2018

Use C++11 constructs and improve comment
Based on feedback by @heplesser in the code review.
@jougs

jougs approved these changes Jun 11, 2018

Nice. Thanks!

@jougs jougs merged commit 061b1d4 into nest:master Jun 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sanjayankur31 sanjayankur31 deleted the sanjayankur31:fix-825 branch Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment