New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust send_recv_count_target_data_ #999

Merged
merged 2 commits into from Aug 14, 2018

Conversation

Projects
None yet
4 participants
@suku248
Contributor

suku248 commented Aug 8, 2018

send_recv_count_target_data_ should be adjusted in MPIManager::increase_buffer_size_target_data().

Calling set_buffer_size_target_data() ensures this.

@jakobj and @wschenck could you please review this?

@wschenck

Looks good to me!

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Aug 9, 2018

Contributor

@hakonsbm Could you also check if this change has an effect on benchmarks with more than one MPI process?

Contributor

heplesser commented Aug 9, 2018

@hakonsbm Could you also check if this change has an effect on benchmarks with more than one MPI process?

@heplesser heplesser added this to the NEST 2.16 milestone Aug 9, 2018

@hakonsbm

There is no change in performance when benchmarking brunel-2000_newconnect.sli in parallel. So with a small adjustment to the comments, I'm happy.

Show outdated Hide outdated nestkernel/mpi_manager.h
Show outdated Hide outdated nestkernel/mpi_manager.h

@heplesser heplesser merged commit e6936d9 into nest:master Aug 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment