Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust send_recv_count_target_data_ #999

Merged
merged 2 commits into from Aug 14, 2018

Conversation

@suku248
Copy link
Contributor

@suku248 suku248 commented Aug 8, 2018

send_recv_count_target_data_ should be adjusted in MPIManager::increase_buffer_size_target_data().

Calling set_buffer_size_target_data() ensures this.

@jakobj and @wschenck could you please review this?

Copy link
Contributor

@wschenck wschenck left a comment

Looks good to me!

@heplesser
Copy link
Contributor

@heplesser heplesser commented Aug 9, 2018

@hakonsbm Could you also check if this change has an effect on benchmarks with more than one MPI process?

@heplesser heplesser added this to the NEST 2.16 milestone Aug 9, 2018
Copy link
Contributor

@hakonsbm hakonsbm left a comment

There is no change in performance when benchmarking brunel-2000_newconnect.sli in parallel. So with a small adjustment to the comments, I'm happy.

@@ -597,12 +597,14 @@ MPIManager::increase_buffer_size_target_data()
if ( buffer_size_target_data_ * growth_factor_buffer_target_data_
< max_buffer_size_target_data_ )
{
buffer_size_target_data_ = static_cast< size_t >(
floor( buffer_size_target_data_ * growth_factor_buffer_target_data_ ) );
// this adjusts also send_recv_count_target_data_per_rank_

This comment has been minimized.

@hakonsbm

hakonsbm Aug 9, 2018
Contributor

Should be "also adjusts".

This comment has been minimized.

@suku248

suku248 Aug 10, 2018
Author Contributor

Agreed!

}
else
{
buffer_size_target_data_ = max_buffer_size_target_data_;
// this adjusts also send_recv_count_target_data_per_rank_

This comment has been minimized.

@hakonsbm

hakonsbm Aug 9, 2018
Contributor

Same as above.

@heplesser heplesser merged commit e6936d9 into nest:master Aug 14, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.