GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send_recv_count_target_data_ should be adjusted in MPIManager::increase_buffer_size_target_data().
Calling set_buffer_size_target_data() ensures this.
@jakobj and @wschenck could you please review this?
Adjust send_recv_count_target_data_ when target-data comm buffer size…
… is increased
Looks good to me!
@hakonsbm Could you also check if this change has an effect on benchmarks with more than one MPI process?
There is no change in performance when benchmarking brunel-2000_newconnect.sli in parallel. So with a small adjustment to the comments, I'm happy.
Correct word order in comments