Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TC39 decorators that is available since TypeScript 5.0 #11414

Closed
1 task done
cnshenj opened this issue Mar 31, 2023 · 3 comments
Closed
1 task done

Support TC39 decorators that is available since TypeScript 5.0 #11414

cnshenj opened this issue Mar 31, 2023 · 3 comments
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@cnshenj
Copy link

cnshenj commented Mar 31, 2023

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

TypeScript 5.0 fully supports stage 3 TC39 decorators.

The legacy decorators are still supported: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#differences-with-experimental-legacy-decorators, but the new decorators have some advantages. For example, they work without a special flag, have better type-checking, etc.

Describe the solution you'd like

Support the new TC39 decorators.

Teachability, documentation, adoption, migration strategy

Please see TypeScript documentation.

What is the motivation / use case for changing the behavior?

Keep up with JS/TS evolution.
@cnshenj cnshenj added needs triage This issue has not been looked into type: enhancement 🐺 labels Mar 31, 2023
@micalevisk
Copy link
Member

micalevisk commented Mar 31, 2023 •
edited
Loading

we cannot have that for now due to the lack on parameter decorators.

image

@jmcdo29
Copy link
Member

jmcdo29 commented Mar 31, 2023

Also no emitted decorator metadata support, which nest heavily uses

@nestjs nestjs locked and limited conversation to collaborators Apr 4, 2023
@kamilmysliwiec
Copy link
Member

I don't think we'll support JS decorators till the metadata support & parameter decorators are implemented

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cnshenj @micalevisk @kamilmysliwiec @jmcdo29