Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastify http2 and other options doesn´t exist through FastifyAdapter #1950

Closed
PixoDev opened this issue Apr 6, 2019 · 3 comments

Comments

@PixoDev
Copy link

commented Apr 6, 2019

I'm submitting a...


[ ] Regression 
[ ] Bug report
[ ] Feature request
[x ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Create a FastifyAdapter, pass options through the constructor, options like http2 doesnt exists in type ServerOptions

Expected behavior

Http2 option from fastify is defined and ready to use through the FastifyAdapter constructor
(Even if it´s an experimental feature in fastify)

Minimal reproduction of the problem with instructions

-Create a nest application
-Use FastifyAdatper
-Instance it and pass an options object, use http2: true, doesn´t exist, same as Https

repository -> https://github.com/PixoDev/fastify-options

-run npm install
-run npm run start:dev
-error appears in the console

What is the motivation / use case for changing the behavior?

-Use http2 instead of http1.1 for better performance

Environment


Nest version: 6.0

 
For Tooling issues:
- Node version: v10.15.0
- Platform:  Windows 10 

Others:

@kamilmysliwiec

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Please, provide a minimal repository which reproduces your issue.

@PixoDev

This comment has been minimized.

Copy link
Author

commented Apr 7, 2019

Edited!, thank you for your time

kamilmysliwiec added a commit that referenced this issue Apr 10, 2019
@kamilmysliwiec

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Fixed in 6.1.0

Thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.