Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(core) update url for circular dependency in error message #1441

Merged
merged 1 commit into from Jan 14, 2019

Conversation

@iblamefish
Copy link

commented Jan 13, 2019

Fixes the url in INVALID_MODULE_MESSAGE.

This closes #1369

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Message links to https://docs.nestjs.com/advanced/circular-dependency, redirecting to docs homepage

Issue Number: #1369

What is the new behavior?

Message correctly links to https://docs.nestjs.com/fundamentals/circular-dependency

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

bugfix(core) update url for circular dependency in error message
Fixes the url in INVALID_MODULE_MESSAGE

This closes #1369
@coveralls

This comment has been minimized.

Copy link

commented Jan 13, 2019

Pull Request Test Coverage Report for Build 1376

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.773%

Totals Coverage Status
Change from base Build 1339: 0.0%
Covered Lines: 2851
Relevant Lines: 2974

💛 - Coveralls
1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Jan 13, 2019

Pull Request Test Coverage Report for Build 1376

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.773%

Totals Coverage Status
Change from base Build 1339: 0.0%
Covered Lines: 2851
Relevant Lines: 2974

💛 - Coveralls
@kamilmysliwiec

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Thanks! LGTM

@kamilmysliwiec kamilmysliwiec merged commit 0f788ef into nestjs:master Jan 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.773%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.