New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core) allow the NestModule.configure() method to be async #2767
Conversation
Pull Request Test Coverage Report for Build 4264
💛 - Coveralls |
@@ -1,5 +1,5 @@ | |||
import { MiddlewareConsumer } from '../middleware/middleware-consumer.interface'; | |||
|
|||
export interface NestModule { | |||
configure(consumer: MiddlewareConsumer): MiddlewareConsumer | void; | |||
configure(consumer: MiddlewareConsumer): Promise<MiddlewareConsumer | void>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we can just remove the return type here entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're absolutely right.
fix(deps): update dependency graphql to v14.5.3
chore(deps): update dependency @types/jest to v24.0.18
…ckages fix(deps): update dependency apollo-server-express to v2.9.0
Could you rebase your PR to the latest changes on master? It seems that it contains lots of renovate commits now:) |
ups... sorry about that! I'll do it right now. |
The header of this issue is a lie:). I don't want to merge 54 commits... Bellow are the changes for CR: |
Thanks! |
Thank you! Can't wait for 6.6.0 release:) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1384
What is the new behavior?
Allows the NestModule.configure() method to be asynchronous. More details can be found on #1384.
Does this PR introduce a breaking change?
Other information