Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core) allow the NestModule.configure() method to be async #2767

Merged
merged 15 commits into from Aug 26, 2019

Conversation

zailic
Copy link
Contributor

@zailic zailic commented Aug 18, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1384

What is the new behavior?

Allows the NestModule.configure() method to be asynchronous. More details can be found on #1384.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zailic zailic changed the title Ionut zailic issue no1384 Alow the NestModule.configure() method to be async Aug 18, 2019
@coveralls
Copy link

coveralls commented Aug 18, 2019

Pull Request Test Coverage Report for Build 4264

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.236%

Totals Coverage Status
Change from base Build 4098: 0.0%
Covered Lines: 3638
Relevant Lines: 3820

💛 - Coveralls

@@ -1,5 +1,5 @@
import { MiddlewareConsumer } from '../middleware/middleware-consumer.interface';

export interface NestModule {
configure(consumer: MiddlewareConsumer): MiddlewareConsumer | void;
configure(consumer: MiddlewareConsumer): Promise<MiddlewareConsumer | void>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can just remove the return type here entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're absolutely right.

@kamilmysliwiec
Copy link
Member

Could you rebase your PR to the latest changes on master? It seems that it contains lots of renovate commits now:)

@zailic
Copy link
Contributor Author

zailic commented Aug 24, 2019

ups... sorry about that! I'll do it right now.

@kamilmysliwiec kamilmysliwiec changed the title Alow the NestModule.configure() method to be async feat(core) allow the NestModule.configure() method to be async Aug 24, 2019
@zailic
Copy link
Contributor Author

zailic commented Aug 24, 2019

The header of this issue is a lie:). I don't want to merge 54 commits... Bellow are the changes for CR:
master...zailic:IonutZailic-IssueNo1384

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.6.0 August 26, 2019 08:18
@kamilmysliwiec kamilmysliwiec merged commit 3f496af into nestjs:6.6.0 Aug 26, 2019
@kamilmysliwiec
Copy link
Member

Thanks!

@zailic
Copy link
Contributor Author

zailic commented Aug 26, 2019

Thank you! Can't wait for 6.6.0 release:)

@zailic zailic deleted the IonutZailic-IssueNo1384 branch August 26, 2019 12:09
@lock
Copy link

lock bot commented Nov 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants