Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): removing duplicated axios interfaces #470

Merged

Conversation

Projects
None yet
3 participants
@patrickhousley
Copy link
Contributor

patrickhousley commented Mar 4, 2018

  • Removed the deprecated package @types/axios.
  • Removed the duplicated axios interfaces.
  • Updated the HttpService to use the interfaces provided by axios.
fix(common): removing duplicated axios interfaces
- Removed the deprecated package @types/axios.
- Removed the duplicated axios interfaces.
- Updated the HttpService to use the interfaces provided by axios.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 4, 2018

Coverage Status

Coverage remained the same at 93.866% when pulling 21be3f8 on patrickhousley:bugfix/axios-interfaces into eda82af on nestjs:master.

@kamilmysliwiec

This comment has been minimized.

Copy link
Member

kamilmysliwiec commented Mar 9, 2018

Thanks 🙂

@kamilmysliwiec kamilmysliwiec merged commit e51f3e0 into nestjs:master Mar 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.866%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.