Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(microservices/nats): check replyTo channel existence #5530

Merged
merged 2 commits into from Oct 29, 2020

Conversation

vbrvk
Copy link
Contributor

@vbrvk vbrvk commented Oct 5, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4874

What is the new behavior?

App doesn't crash for valid request

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@coveralls
Copy link

coveralls commented Oct 5, 2020

Pull Request Test Coverage Report for Build c71a66d5-5fed-421a-b033-e2c93189f5bf

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 94.82%

Totals Coverage Status
Change from base Build 8866f8ae-b389-4900-bbda-251e1de94805: 0.002%
Covered Lines: 4924
Relevant Lines: 5193

💛 - Coveralls

@vbrvk
Copy link
Contributor Author

vbrvk commented Oct 5, 2020

Linter failed because of Unexpected empty arrow function @typescript-eslint/no-empty-function
Can I mark the line as ignored by linter or what should I do? 🤔

@kamilmysliwiec kamilmysliwiec merged commit ed62048 into nestjs:master Oct 29, 2020
@vbrvk vbrvk deleted the issue-4874 branch October 30, 2020 11:43
leeklife pushed a commit to leeklife/nest that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants