Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): listen method is void return type #5820

Merged
merged 2 commits into from Nov 30, 2020

Conversation

kaznovac
Copy link
Contributor

state correct return type (void) on the NestMicroservice.listen method

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

return type is misleading this is not a breaking-change

Other information

@coveralls
Copy link

coveralls commented Nov 28, 2020

Pull Request Test Coverage Report for Build 1e3b132f-bd5e-47cb-ba9e-28a894d906e2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.651%

Totals Coverage Status
Change from base Build 23fac820-c861-40be-bf3c-a307cbe03615: 0.0%
Covered Lines: 5008
Relevant Lines: 5291

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 3a97eec into nestjs:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants