Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (5)
@kamilmysliwiec kamilmysliwiec Jul 18, 2022
Out of curiosity, why `new Logger` here (every time error occurs)?
Outdated
...tform-express/adapters/express-adapter.ts
jmcdo29
@micalevisk micalevisk Jul 17, 2022
now that this isn't private anymore, what about renaming it to `handleError`?
Outdated
...ges/common/file-stream/streamable-file.ts
@micalevisk micalevisk Jul 17, 2022
```suggestion body.getStream().once('error', (err: Error) => { ``` to prevent the error 'Cannot set headers after they are sent to the client' if for whatever reason the _error_ event is emitted multiple times (not sure if this is possible tho)
Outdated
...tform-express/adapters/express-adapter.ts
@micalevisk micalevisk Jul 17, 2022
```suggestion export interface StreamableHandlerResponse { ```
Outdated
...ges/common/file-stream/streamable-file.ts
@micalevisk micalevisk Jun 22, 2022
```suggestion protected handler: (err: Error, response: StreamableHandlerResponse) => void = ( ``` so others can customize this one
Outdated
...ges/common/file-stream/streamable-file.ts
micalevisk jmcdo29