Skip to content

feat: expose validate() as abstract#1641

Merged
kamilmysliwiec merged 2 commits into
nestjs:11.0.0from
alexey-pelykh:feat/expose-validate-as-abstract
Nov 25, 2024
Merged

feat: expose validate() as abstract#1641
kamilmysliwiec merged 2 commits into
nestjs:11.0.0from
alexey-pelykh:feat/expose-validate-as-abstract

Conversation

@alexey-pelykh

@alexey-pelykh alexey-pelykh commented Apr 27, 2024

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: typing enhancement

What is the current behavior?

extends PassportStrategy(Strategy) does not inform developer that validate must be implement and about its signature.

What is the new behavior?

extends PassportStrategy(Strategy) informs developer that validate must be implement and about its signature.

Does this PR introduce a breaking change?

  • Yes
  • No

In case there are abstract classes that derive from PassportStrategy(Strategy) that didn't mark validate() as abstract, those would issue a build error now.

Other information

@alexey-pelykh alexey-pelykh force-pushed the feat/expose-validate-as-abstract branch from 1fb5ae9 to 613f3c4 Compare April 28, 2024 05:28
@alexey-pelykh alexey-pelykh reopened this Apr 28, 2024
@alexey-pelykh alexey-pelykh force-pushed the feat/expose-validate-as-abstract branch from 4bd2d57 to f586a03 Compare April 28, 2024 06:54
@kamilmysliwiec kamilmysliwiec added this to the 11.0. milestone Nov 25, 2024
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 11.0.0 November 25, 2024 09:45
@kamilmysliwiec kamilmysliwiec merged commit df8681e into nestjs:11.0.0 Nov 25, 2024
@alexey-pelykh alexey-pelykh deleted the feat/expose-validate-as-abstract branch November 25, 2024 09:54
@kamilmysliwiec kamilmysliwiec mentioned this pull request Nov 25, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants