Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up gitignore and added more common files that should be ignored #160

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Tidy up gitignore and added more common files that should be ignored #160

merged 1 commit into from
Jul 10, 2020

Conversation

BeeHiveJava
Copy link
Contributor

Proposed change

Cleaned up gitignore and added common Visual Studio / Jetbrains files.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

@BeeHiveJava BeeHiveJava added the enhancement New feature or request label Jul 10, 2020
@BeeHiveJava BeeHiveJava self-assigned this Jul 10, 2020
helto4real
helto4real approved these changes Jul 10, 2020
View reviewed changes
Copy link
Collaborator

@helto4real helto4real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very much nices. Thanks!

@helto4real helto4real merged commit 657ed80 into dev Jul 10, 2020
@helto4real helto4real deleted the feat/gitignore branch July 10, 2020 19:38
Ikcelaks pushed a commit to Ikcelaks/netdaemon that referenced this pull request Dec 23, 2022
@BeeHiveJava
chore: tidy up gitignore and added more common files that should be i…
a1d9674 
…gnored (net-daemon#160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helto4real helto4real helto4real approved these changes

Assignees

@BeeHiveJava BeeHiveJava

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeeHiveJava @helto4real