From 2121498008ca15a8efb2f29bb014f7e7323a830f Mon Sep 17 00:00:00 2001 From: Frank Bakker Date: Thu, 15 Dec 2022 20:51:34 +0100 Subject: [PATCH 1/4] ignore CA1852 --- .linting/roslynator.ruleset | 1 + 1 file changed, 1 insertion(+) diff --git a/.linting/roslynator.ruleset b/.linting/roslynator.ruleset index 6d88ea49f..25d24d039 100644 --- a/.linting/roslynator.ruleset +++ b/.linting/roslynator.ruleset @@ -37,6 +37,7 @@ Just add ruleset file to a solution and open it. + \ No newline at end of file From 6d127cd2e967048aa6e32886c8a4755fa00bd79b Mon Sep 17 00:00:00 2001 From: Frank Bakker Date: Thu, 15 Dec 2022 21:03:40 +0100 Subject: [PATCH 2/4] Add NetDaemon.Runtime.Tests to Coverage --- .github/workflows/ci_build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci_build.yml b/.github/workflows/ci_build.yml index 38a16eab7..daef3b296 100644 --- a/.github/workflows/ci_build.yml +++ b/.github/workflows/ci_build.yml @@ -34,6 +34,7 @@ jobs: dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Extensions/NetDaemon.Extensions.Scheduling.Tests dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Client/NetDaemon.HassClient.Tests dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=lcov;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/AppModel/NetDaemon.AppModel.Tests + dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Runtime/NetDaemon.Runtime.Tests - name: 📨 Publish coverage report to coveralls.io uses: coverallsapp/github-action@master From b97280edab664c52b60bc2124950e2940551e99a Mon Sep 17 00:00:00 2001 From: Frank Bakker Date: Thu, 15 Dec 2022 21:48:20 +0100 Subject: [PATCH 3/4] try json format iso lcov --- .github/workflows/ci_build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_build.yml b/.github/workflows/ci_build.yml index daef3b296..e611fdb72 100644 --- a/.github/workflows/ci_build.yml +++ b/.github/workflows/ci_build.yml @@ -33,7 +33,7 @@ jobs: dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/HassModel/NetDaemon.HassModel.Tests dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Extensions/NetDaemon.Extensions.Scheduling.Tests dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Client/NetDaemon.HassClient.Tests - dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=lcov;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/AppModel/NetDaemon.AppModel.Tests + dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/AppModel/NetDaemon.AppModel.Tests dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Runtime/NetDaemon.Runtime.Tests - name: 📨 Publish coverage report to coveralls.io From 11fb8393ef215553a966855720a431885d65419b Mon Sep 17 00:00:00 2001 From: Frank Bakker Date: Thu, 15 Dec 2022 21:49:07 +0100 Subject: [PATCH 4/4] make last lcov --- .github/workflows/ci_build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_build.yml b/.github/workflows/ci_build.yml index e611fdb72..1a6074ea9 100644 --- a/.github/workflows/ci_build.yml +++ b/.github/workflows/ci_build.yml @@ -34,7 +34,7 @@ jobs: dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Extensions/NetDaemon.Extensions.Scheduling.Tests dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Client/NetDaemon.HassClient.Tests dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/AppModel/NetDaemon.AppModel.Tests - dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=json;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Runtime/NetDaemon.Runtime.Tests + dotnet test -v minimal '/p:CollectCoverage=true;CoverletOutputFormat=lcov;MergeWith=${{github.workspace}}/codecover.json;CoverletOutput=${{github.workspace}}/codecover' src/Runtime/NetDaemon.Runtime.Tests - name: 📨 Publish coverage report to coveralls.io uses: coverallsapp/github-action@master