Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that :FOR[TWEAKSCALE] thingy on the patches #21

Open
Lisias opened this issue Feb 18, 2019 · 14 comments

Comments

@Lisias
Copy link

commented Feb 18, 2019

Tonka appears to have a point. Check and (probably) fix everyhing on /patches.

We need to check if this will not break for previous versions of Module Manager - and if it breaks, state the MININUM Module Manager compatible on the documentation (and CKAN).

Refenreces:
https://forum.kerbalspaceprogram.com/index.php?/topic/179030-14x151-161-tweakscale-under-new-management-2410-2019-0216/&page=10&tab=comments#comment-3542929

https://forum.kerbalspaceprogram.com/index.php?/topic/179030-14x151-161-tweakscale-under-new-management-2410-2019-0216/&page=10&tab=comments#comment-3542936

@Lisias Lisias self-assigned this Feb 18, 2019

@Lisias Lisias added the question label Feb 18, 2019

@Lisias

This comment has been minimized.

Copy link
Author

commented Feb 18, 2019

Marked as "question" as I need to spend some time reading documentation answering my own questions. :)

@Lisias Lisias added this to the TweakScale 2.4.1.1 milestone Feb 18, 2019

@Lisias Lisias added enhancement and removed question labels Mar 6, 2019

@Lisias

This comment has been minimized.

Copy link
Author

commented Mar 6, 2019

I'm working on it. Since I LOG of patches are being edited, they will be tested before the release - a typo, and I will break hell loose. :D

I will edit this comment with the Files ( directories( as I commit and test them.

Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* Squad
* SquadExpansion

#21
Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* Squad
* SquadExpansion

#21
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* AIES
* AtomicAge
* BananaForScale
* BetterRovermates

#21
Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* CactEye
* DeadlyReentry
* DST

#21
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* FusTek
* HabPack
* HGR

#21
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* Kethane
* KH SSE
* KOSMOS

#21
Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* KSO
* KSPX
* KW

https://github.com/net-lisias-ksp/TweakScale/issues/21Implementing that :FOR thingy for :
* Kethane
* KH SSE
* KOSMOS

#21
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* Mark IV System
* MechJeb
* MiningEx

#21
Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* Mk3 Hypersonic Systems
* Mk3X

#21
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Lisias added a commit that referenced this issue Mar 6, 2019
Implementing that :FOR thingy for :
* TAC
* TAL Cargo
* Tantares

#21
Lisias added a commit that referenced this issue Mar 6, 2019
@Lisias

This comment has been minimized.

Copy link
Author

commented Mar 6, 2019

Had fired the KSP on a interim fork of Module Manager, instrumented to be even more picky. No detected issues on these patches (but got a bunch on other's mods patches - It's New Issue Fest! :) ).

Closing this.

Lisias added a commit to net-lisias-kspw/RetroFuture that referenced this issue Apr 1, 2019

@Lisias Lisias modified the milestones: TweakScale 2.4.2.0, 2.5.0.0 May 5, 2019

@Lisias

This comment has been minimized.

Copy link
Author

commented May 5, 2019

Reopening it to fix the patches for Near Future Aeronautics

@Lisias Lisias reopened this May 5, 2019

Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* Squad
* SquadExpansion

#21
Lisias added a commit that referenced this issue May 12, 2019
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* AIES
* AtomicAge
* BananaForScale
* BetterRovermates

#21
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* CactEye
* DeadlyReentry
* DST

#21
Lisias added a commit that referenced this issue May 12, 2019
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* FusTek
* HabPack
* HGR

#21
Lisias added a commit that referenced this issue May 12, 2019
Lisias added a commit that referenced this issue May 12, 2019
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* Kethane
* KH SSE
* KOSMOS

#21
Lisias added a commit that referenced this issue May 12, 2019
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* Landerton
* Lynx

#21
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* Mark IV System
* MechJeb
* MiningEx

#21
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* Mk3 Hypersonic Systems
* Mk3X

#21
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* Nerta
* Nova Punch

#21
Lisias added a commit that referenced this issue May 12, 2019
Lisias added a commit that referenced this issue May 12, 2019
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* RT
* SDHI
* SSPXR

#21
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* TAC
* TAL Cargo
* Tantares

#21
Lisias added a commit that referenced this issue May 12, 2019
Implementing that :FOR thingy for :
* TVPP
* UKLD
* VSR

#21
@Lisias

This comment has been minimized.

Copy link
Author

commented Jun 8, 2019

Issue #34 is related to this. Rogue patches (usually pretty old ones) that would break under the new behaviour can now be diagnosed.

Lisias added a commit that referenced this issue Jul 22, 2019
@Lisias

This comment has been minimized.

Copy link
Author

commented Jul 22, 2019

I need to cook a way to tie TWEAKSCALEEXPONENTS and TWEAKSCALEBEHAVIOR to the Module Manager passes (:FOR) without creating a hard dependency for ModuleManager. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.