Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing being ran over by other mods #31

Open
Lisias opened this issue Mar 17, 2019 · 5 comments

Comments

Projects
None yet
1 participant
@Lisias
Copy link

commented Mar 17, 2019

This isn't exact an issue but an Task.

Since some more Mods are currently mangling GameDatabase on the Main Menu Scene, and since TweakScale must be last of the Manglers on that event chain, and since TweakScale needs to have their internal affairs in order before the user loads a savegame (what's inevitably happens before loading the Space Center!) due the prefab being applied too on craft from savegames (novelty on 1.5.1 or 1.6.1, last time I checked it I was playing 1.4.x).

@Lisias

This comment has been minimized.

Copy link
Author

commented Mar 17, 2019

Latest commit on this effort: b885e54

@Lisias

This comment has been minimized.

Copy link
Author

commented Mar 17, 2019

A Beta Release to check if I didn't made any serious mistake - as well to see if by luck this really fixes something.

WARNING

This can break your KSP, ruin your Windows, kill your pet and poison your kids. :D

By the Holy Kerbol that enlighten us, please use this only under my instructions, and only if I ask you to do so! Twice. :)

TweakScale-Beta-2.4.1.1.zip

@Lisias Lisias added this to the 2.4.3.0 milestone May 5, 2019

Lisias added a commit that referenced this issue May 12, 2019

Lisias added a commit that referenced this issue May 12, 2019

@Lisias

This comment has been minimized.

Copy link
Author

commented May 19, 2019

This stunt apparently managed to stick - at least, it didn't make things worse.

Additionally, @Jammer-TD test runs on #42 (comment) suggests that the Prefab post initialization instrumenting is now able to survive Mission History, ScanSAT and KIS:

[LOG 20:21:08.497] TweakScale::WriteDryCost: Started
[LOG 20:21:08.498] [ModuleManager] Total loading Time = 243.598s
[LOG 20:21:08.920] ADDON BINDER: Create binding redirect: ClickThroughBlocker, Version=0.1.6.10, Culture=neutral, PublicKeyToken=null => ClickThroughBlocker, Version=0.1.7.2, Culture=n
[LOG 20:21:08.922] Tweak 'OnOrbitRightKerbal' matched kerbal model: [Transform:OrbitScene/Kerbals/maleEVA_inverted]
[LOG 20:21:08.923] Equipped part on kerbal model in main screen: KIS.bomb1
[LOG 20:21:08.923] Equipped part on kerbal model in main screen: KIS.Container1
[LOG 20:21:08.923] Tweak 'OnOrbitLeftKerbal' matched kerbal model: [Transform:OrbitScene/Kerbals/maleEVA_side]
[LOG 20:21:08.924] Equipped part on kerbal model in main screen: ScienceBox
[LOG 20:21:08.924] Tweak 'OnOrbitMiddleKerbal' matched kerbal model: [Transform:OrbitScene/Kerbals/maleEVA_center]
[LOG 20:21:08.924] Equipped part on kerbal model in main screen: KIS.electricScrewdriver
[LOG 20:21:08.924] Tweak 'OnOrbitFemaleKerbal' matched kerbal model: [Transform:OrbitScene/Kerbals/femaleEVA]
[LOG 20:21:08.924] Equipped part on kerbal model in main screen: KIS.wrench
[LOG 20:21:08.925] Equipped part on kerbal model in main screen: KIS.guide
[LOG 20:21:08.925] Tweak 'OnMunLoneKerbal' matched kerbal model: [Transform:MunScene/Kerbals/maleEVA]
[LOG 20:21:08.925] Equipped part on kerbal model in main screen: KIS.electricScrewdriver
[LOG 20:21:08.925] Equipped part on kerbal model in main screen: KIS.Container1
[LOG 20:21:08.932] [ScenarioTypes]: List Created 24 scenario types loaded from 55 loaded assemblies.
[LOG 20:21:08.938] [ApplicationLauncher] Awake False
[LOG 20:21:08.939] [ApplicationLauncher] SpawnSimpleLayout: VerticalTopDown
[LOG 20:21:08.949] ScaleModList: listSize 41 maxListSize 0
[LOG 20:21:08.952] [UiApp] Awake: MessageSystem
[LOG 20:21:08.953] [ApplicationLauncher] OnSceneLoadedGUIReady: scene MAINMENU ShouldBeVisible() True ShouldBeOnTop() True iIsPositionedAtTop True
[LOG 20:21:08.961] [SCANsat] Shader asset bundle loaded; using platform bundle: scan_shaders-windows.scan
[LOG 20:21:08.966] [SCANsat] Unity skin asset bundle loaded
[LOG 20:21:08.969] [SCANsat] Icon asset bundle loaded
[LOG 20:21:09.073] [SCANsat] UI prefab bundle loaded and processed
[LOG 20:21:09.073] [SCANsat] All SCANsat asset bundles loaded
[LOG 20:21:09.122] IRS: Successfully loaded all prefabs from AssetBundle
[WRN 20:21:09.162] [TweakScale] Removing TweakScale support for FSfloatEnd.
[ERR 20:21:09.162] [TweakScale] Part FSfloatEnd didn't passed the sanity check due using FSbuoyancy module - see issue #9 https://github.com/net-lisias-ksp/TweakScale/issues/9.

[WRN 20:21:09.162] [TweakScale] Removing TweakScale support for FSfloatEndTail.
[ERR 20:21:09.162] [TweakScale] Part FSfloatEndTail didn't passed the sanity check due using FSbuoyancy module - see issue #9 https://github.com/net-lisias-ksp/TweakScale/issues/9.

[WRN 20:21:09.162] [TweakScale] Removing TweakScale support for FSfloatGearbay.
[ERR 20:21:09.162] [TweakScale] Part FSfloatGearbay didn't passed the sanity check due using FSbuoyancy module - see issue #9 https://github.com/net-lisias-ksp/TweakScale/issues/9.

[WRN 20:21:09.162] [TweakScale] Removing TweakScale support for FSfloatStraight.
[ERR 20:21:09.162] [TweakScale] Part FSfloatStraight didn't passed the sanity check due using FSbuoyancy module - see issue #9 https://github.com/net-lisias-ksp/TweakScale/issues/9.

[WRN 20:21:09.162] [TweakScale] Removing TweakScale support for FSfloatStrut.
[ERR 20:21:09.162] [TweakScale] Part FSfloatStrut didn't passed the sanity check due using FSbuoyancy module - see issue #9 https://github.com/net-lisias-ksp/TweakScale/issues/9.

[WRN 20:21:09.162] [TweakScale] Removing TweakScale support for FSlandingPads.
[ERR 20:21:09.162] [TweakScale] Part FSlandingPads didn't passed the sanity check due using FSbuoyancy module - see issue #9 https://github.com/net-lisias-ksp/TweakScale/issues/9.

[ERR 20:21:09.162] TweakScale::PrefabDryCostWriter: negative dryCost: part=IFSHexcanSolid, DryCost=-1.66893E-05

[LOG 20:21:09.166] TweakScale::WriteDryCost: Concluded

(i.e. - the stunt apparently is detecting when something else is mangling the GameDatabase and manages to delay the task!)

So I'm closing this as FIXED. for while :)

@Lisias

This comment has been minimized.

Copy link
Author

commented Jun 18, 2019

It's happening again. =/

@Lisias

This comment has been minimized.

Copy link
Author

commented Jul 7, 2019

I got news that Pre Releaser 2.5.0.2 had this problem solved on the field for at least one user.

See this Post on TweakScale's Thread .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.