Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sanity Check: duplicated properties #34

Closed
Lisias opened this issue Mar 31, 2019 · 3 comments

Comments

Projects
None yet
1 participant
@Lisias
Copy link

commented Mar 31, 2019

Due this stunt, properly explained here, a new Sanity Check needs to be implemented.

This stunt essentially shoves Free Scaling in every part on the GameDatabase that has "Cone" in the name!This not only mangles the prefab, but also corrupts craft files and savegames, as they are "tainted" by this misconfiguration  Once you delete the Add'On and Module Manager rebuilds the cache (and the GameDatabase), all your TweakScaled parts gets rescaled terribly wrong!

So, when you load your craft and savegames after installing such Add'On, a lot of parts are wrong (There're more patches like this! The thing is way "greedy" on this). So you "fix" them, and now your parts are incompatible with everybody that doesn't have that Add'On too. And when you uninstall the thing, your crafts and savegames became "corrupted", as the original "type" is back to be effective and Kraken knows what would happen - one of my crafts got the Cones so big that the craft ended up inside an 'egg" - unflyable. And this includes the savegames. Yeah, I need to fix them all on my installment due this.  

It worth to mention that this same stunt when applied on a non visual feature (as resource consumption and mass!) would summon the Sacred Rage of the Krakens on your KSP. This has potential to be very nasty if you don't use the latest TweakScale hat withdraw itself from such parts!

This check should:

  • Detect any duplicated properties on each Part's TweakScale module from prefab
  • Check against a "whitelist" where (hypothetical) properties that can be duplicated would be ruled out (currently none)
  • And then withdraw itself from the Part if non whitelisted properties are duplicated.
    • An error entry should be added to the log file, pinpointing to this issue.

After Math:

Since this have a highly destructive potential, as Stock parts (between others) that used to work suddenly became UnTweakScaled, this has a huge potential to ruining savegames.

problem described

The user should be warned and ideally the game must be finished. Whatever it was installed by last, it must be rolled back.

@Lisias Lisias self-assigned this Apr 2, 2019

@Lisias Lisias added this to the 2.4.3.0 milestone May 5, 2019

Lisias added a commit that referenced this issue Jun 8, 2019

@Lisias

This comment has been minimized.

Copy link
Author

commented Jun 8, 2019

Implemented on commit eea6046

@Lisias Lisias closed this Jun 8, 2019

Lisias added a commit that referenced this issue Jun 8, 2019

Lisias added a commit that referenced this issue Jun 8, 2019

Lisias added a commit to net-lisias-kspw/TundraExploration that referenced this issue Jun 9, 2019

@Lisias

This comment has been minimized.

Copy link
Author

commented Jun 9, 2019

Yep. It works… =P

182 Fatals on my main KSP installment. This is going to be interesting...

Screen Shot 2019-06-09 at 14 48 56

@Lisias

This comment has been minimized.

Copy link
Author

commented Jun 14, 2019

Interesting. My old Career instalment (yet on 1.4.3!!) got "only" 12 Fatalities. Way better than the "Company" installment, this one updated to 1.7.0 + MH.

The Career has a bit less Add'Ons than Company, but yet it has a good basket of them.

On a blind guess, this appears to be something that was always there, but only started to bite hard in the last year (from 1.5 ahead, perhaps?)

Screen Shot 2019-06-13 at 22 10 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.