Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mk4 System Patch (addendum) #58

Closed
deimos790 opened this issue Jul 2, 2019 · 4 comments
Assignees
Labels
bug
Milestone

Comments

@deimos790
Copy link

@deimos790 deimos790 commented Jul 2, 2019

This causes conflict...


@PART[mk4cockpit*] // 
{
    %MODULE[TweakScale]
    {
        type = stack
		defaultScale = 5.0
    }
}

@PART[mk4cockpit-shoulder*] // 
{
    %MODULE[TweakScale]
    {
        type = surface
    }
}
@Lisias Lisias added the bug label Jul 4, 2019
@Lisias Lisias added this to the 2.4.3.1 milestone Jul 4, 2019
@Lisias

This comment has been minimized.

Copy link

@Lisias Lisias commented Jul 4, 2019

Yes, thank you for the report.

It's already fixed on this commit to be included on the next 2.4.3.1 release.

Thanks again!

@Lisias Lisias closed this Jul 4, 2019
@Annastasya77

This comment has been minimized.

Copy link

@Annastasya77 Annastasya77 commented Jul 9, 2019

Line 241 causes 3 Issue #34 Fatal errors still even after your commit changes to MarkIVSystem_TweakScale.cfg. Judging by your change for cockpits I'm guessing you would also want an edit something like this:

@part[mk4cockpit-shoulder-1,mk4cockpit-shoulder-2,mk4cockpit-shoulder-3] //

KSP (Truncated for upload size).log

@Lisias Lisias changed the title Mk4 System Patch (duplicate) Mk4 System Patch (addendum) Jul 22, 2019
@Lisias

This comment has been minimized.

Copy link

@Lisias Lisias commented Jul 22, 2019

Fair enough. @Annastasya77 has a point, it's a good addendum to @deimos790 's report

@Lisias Lisias reopened this Jul 22, 2019
Lisias added a commit that referenced this issue Jul 22, 2019
#58
@Lisias

This comment has been minimized.

Copy link

@Lisias Lisias commented Jul 22, 2019

Fixed on on commit: c5f201f

@Lisias Lisias closed this Jul 22, 2019
@Lisias Lisias self-assigned this Jul 22, 2019
Lisias added a commit that referenced this issue Jul 25, 2019
#58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.