Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in version file for 2.4.3.8 #81

Closed
HebaruSan opened this issue Oct 23, 2019 · 3 comments
Closed

Syntax error in version file for 2.4.3.8 #81

HebaruSan opened this issue Oct 23, 2019 · 3 comments
Assignees
Labels
bug Something isn't working My fault I Borked on this one
Milestone

Comments

@HebaruSan
Copy link

HebaruSan commented Oct 23, 2019

The download for 2.4.3.8 contains this metadata:

{
	"NAME"		: "TweakScale",
	"URL"		: "https://github.com/net-lisias-ksp/TweakScale/blob/master/TweakScale.version",
	"DOWNLOAD"	: "https://github.com/net-lisias-ksp/TweakScale/releases",
	"CHANGE_LOG"	: "https://raw.githubusercontent.com/net-lisias-ksp/TweakScale/CHANGE_LOG.md",
	"CHANGE_LOG_URL": "https://raw.githubusercontent.com/net-lisias-ksp/TweakScale/CHANGES.md",
	"VERSION":{
		"MAJOR":2,
		"MINOR":4,
		"PATCH":3,
		"BUILD":8
		},
	"KSP_VERSION_MIN":{
		"MAJOR":1,
		"MINOR":4,
		"PATCH":1
		}
	"KSP_VERSION_MAX":{
		"MAJOR":1,
		"MINOR":7,
		"PATCH":99
		}
}

There's a missing comma between KSP_VERSION_MIN and KSP_VERSION_MAX. This is preventing this release from being listed in CKAN.

Unfortunately I can't submit a pull request to fix this because this data is not yet reflected on GitHub:

https://github.com/net-lisias-ksp/TweakScale/blob/master/TweakScale.version

@Lisias
Copy link

Lisias commented Oct 23, 2019

God damned typo, missing a comma. :(.

Fixing it.

@Lisias
Copy link

Lisias commented Oct 23, 2019

That caught with my pants down. It's no doubt, there's a typo on the file.

Screen Shot 2019-10-23 at 11 13 03

But that passed through because KSP-AVC gladly accepted that file, with or without a typo. And I relied on it when testing this thing.

[LOG 11:18:20.828] KSP-AVC -> /Users/lisias/Workspaces/KSP/runtime/1.8.0/GameData/TweakScale/TweakScale.version
        NAME: TweakScale
        URL: https://raw.githubusercontent.com/net-lisias-ksp/TweakScale/master/TweakScale.version
        DOWNLOAD: https://github.com/net-lisias-ksp/TweakScale/releases
        GITHUB: NULL
        DISALLOW_VERSION_OVERRIDE: False
        VERSION: 2.4.3.8
        KSP_VERSION: Any
        KSP_VERSION_MIN: 1.4.1
        KSP_VERSION_MAX: 1.7.99
        CompatibleKspVersion: True
        CompatibleKspVersionMin: True
        CompatibleKspVersionMax: False
        CompatibleGitHubVersion: True

Well, now I know. With KSP-AVC using the file as is, I don't need to fix the distribution and upload everything again on SpaceDock and CurseForge - but I think AVC should at least also kick my balls by allowing a typo on that file while recovering from the parsing error.

And the thing is fixed now. I will close this issue when the master will be pointing the dev branch, were I'm testing things manually this time.

Screen Shot 2019-10-23 at 11 13 24

@Lisias Lisias self-assigned this Oct 23, 2019
@Lisias Lisias added bug Something isn't working My fault I Borked on this one labels Oct 23, 2019
@Lisias Lisias added this to the 2.4.3.8 milestone Oct 23, 2019
@Lisias
Copy link

Lisias commented Oct 23, 2019

master is NOW (damn typos) pinpoint an updated and correct Version file.

I'm sorry for the trouble, I will get better compliance tools on my chain.

@Lisias Lisias closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working My fault I Borked on this one
Projects
None yet
Development

No branches or pull requests

2 participants