Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird issue with SXT parts using FSBuoyancy #9

Closed
Lisias opened this issue Nov 17, 2018 · 10 comments

Comments

Projects
None yet
1 participant
@Lisias
Copy link

commented Nov 17, 2018

1)This is the part unmodified (defaultScale was set to 1.25 because of an error in the TS patch in SXT, but shouldn't matter) - the max floatBuoyancy is 50:

2)This is the part scaled up to 2.0x - note the mysterious new value for floatBuoyancy, which does not persist when launching the craft. Upon launching, right clicking on the part reveals floatBuoyancy maxed out at 102.4 or so, but adjusting floatBuoyancy changes the range back to 0-50.

3)Then, this is the part scaled back down to 1.0x - the floatBuoyancy is now more than it was at 1.25x, for some reason:

  1. Finally, here is the part scaled BACK up to 2.0 after the previous step where I scaled it down to 1.0 - new value for floatBuoyancy again:

https://forum.kerbalspaceprogram.com/index.php?/topic/179030-141151-tweakscale-under-new-management-2018-1127/&do=findComment&comment=3488699

@Lisias Lisias self-assigned this Nov 17, 2018

@Lisias Lisias added the question label Nov 17, 2018

@Lisias

This comment has been minimized.

Copy link
Author

commented Nov 17, 2018

It works for me!

screen shot 2018-11-16 at 23 26 29
screen shot 2018-11-16 at 23 46 33

I need more information:

  1. KSP version used (are you using Making History�?)
  2. SXT version used
  3. I'm assuming the latest orthodox TwekScale version.

For the recored, my test was made using:

  1. KSP 1.4.5 + MH
  2. "My" fork of SXT (just because I'm testing it before a proper release - unlikely I had "fixed" something by accident….)
  3. This Version of TweakScale (Experimental, for logs)
@Lisias

This comment has been minimized.

Copy link
Author

commented Nov 17, 2018

I just tested it with KSP 1.5.1 + MH. Exactly the same add-ons (I just copied from one KSP into another).

Same results: works for me.

@Lisias Lisias added works-for-me and removed works-for-me labels Nov 17, 2018

@Lisias

This comment has been minimized.

Copy link
Author

commented Nov 17, 2018

I realized that I didn't properly reproduces all the steps. Will redo the tests

@Lisias

This comment has been minimized.

Copy link
Author

commented Nov 17, 2018

The behaviour was confirmed

  1. Take two equal parts with FSBuyoancy: screen shot 2018-11-17 at 13 50 45
  2. Test 1:
    1. Scale up one of them: screen shot 2018-11-17 at 13 51 06
    2. Scale down it two times (to 1.0): screen shot 2018-11-17 at 13 51 39
      • Whoopsy… The Buoyancy value is wrong!!
  3. Test 2:
    1. Scale down directly: screen shot 2018-11-17 at 13 52 12
      • Whoopsy… The Buoyancy value is wrong!!
    2. "Fly" the thing: screen shot 2018-11-17 at 13 54 10
      • Whoopsy… The Buoyancy value is wrong!!

E agora, José? — The fraction values are rounding errors, but the buoyancy values are completly messed up when you scale the thing. Why the values are rollback on launch?

@Lisias

This comment has been minimized.

Copy link
Author

commented Nov 17, 2018

Another issue: This is not a round part. The 1.260 scale shouldn't be applied.

This appears to be like the parachutes, check what was done on the chutes and replicate it here.

@Lisias

This comment has been minimized.

Copy link
Author

commented Dec 4, 2018

This can be related (or not) to issue #11 , [see this comment](url
#11 (comment)).

@Lisias

This comment has been minimized.

Copy link
Author

commented Dec 9, 2018

Possible problems with MH parts too. Investigate

Playing around with rescaling other Structual Tubes looks like the scale factors are just off for all of them.  For example, if I scale down a short T-37 3.75m tube to 1.875m it visually looks to be the same size as the T-18 tube, but weighs .544t vs .075t for the short size T-18 tube. Likewise scaling up a T-18 to 3.75m weights .3t vs .6t for a stock size T-37.

https://forum.kerbalspaceprogram.com/index.php?/topic/179030-141151-tweakscale-under-new-management-2018-1127/&do=findComment&comment=3502132

@Lisias Lisias added the bug label Dec 9, 2018

@Lisias

This comment has been minimized.

Copy link
Author

commented Dec 9, 2018

It appears to be a bug. "Promoting" this to a proper status.

@Lisias

This comment has been minimized.

Copy link
Author

commented Dec 29, 2018

TweakScale 2.4.0.7 will "solve" this issue by dropping support for parts using FSBuoyancy. Sorry.

Proper support will be implemented in the new code tree.

@Lisias Lisias added this to the TweakScale3 milestone Dec 29, 2018

Lisias added a commit that referenced this issue Dec 29, 2018

@Lisias

This comment has been minimized.

Copy link
Author

commented Dec 29, 2018

Since this commit kinda of "solve" the problem, I'm closing this.

3becb45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.