Fix using pageant on windows in ruby 19 #34

Merged
merged 6 commits into from Feb 14, 2012

Conversation

Projects
None yet
3 participants

I merged the patch from #14 (by taking master on graffic/net-ssh), resolved the merge conflicts, and fixed a few remaining test issues. On my windows box, all tests pass both in 1.8.7 and 1.9.3

Note: the :forward_agent option still does not work with pageant.

graffic and others added some commits Feb 28, 2011

@graffic graffic test_ket_manager: Tests should pass in windows too. 035cf6b
@graffic graffic All tests pass Ruby 1.9.2 on Windows a87f437
@graffic graffic Added the same description as github has. ef23039
@graffic graffic Adds support for Putty ssh agent and ruby 1.9 (Windows) a5ebe60
rich Merge remote-tracking branch 'graffic/master'
and fix some tests for windows

* graffic/master:
  Adds support for Putty ssh agent and ruby 1.9 (Windows)
  Added the same description as github has.
  All tests pass Ruby 1.9.2 on Windows
  test_ket_manager: Tests should pass in windows too.

Conflicts:
	test/authentication/test_key_manager.rb
	test/transport/test_algorithms.rb
6c878c8
rich pageant.rb - whitespace (tabs to spaces) 28e5396
Collaborator

delano commented Feb 14, 2012

Looks like a good patch. This is a long awaited fix so greatly appreciated!

I do not have a Windows machine to verify it on. I'll pull it into master but I'll need someone to verify it before I create a release. I'll reply on the previous thread and get in touch with a few folks.

@delano delano pushed a commit that referenced this pull request Feb 14, 2012

Delano Mandelbaum Merge pull request #34 from rliebling/master
Fix using pageant on windows in ruby 19
a547758

@delano delano merged commit a547758 into net-ssh:master Feb 14, 2012

Great. thanks. Let me know if you need anything from me.

On Tue, Feb 14, 2012 at 4:14 AM, Delano Mandelbaum <
reply@reply.github.com

wrote:

Looks like a good patch. This is a long awaited fix so greatly appreciated!

I do not have a Windows machine to verify it on. I'll pull it into master
but I'll need someone to verify it before I create a release. I'll reply on
the previous thread and get in touch with a few folks.


Reply to this email directly or view it on GitHub:
#34 (comment)

Shop It To Me is hiring awesome people
http://ShopItToMe.com/jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment