Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large pull request including 3 new features and three upgrades #477

Merged
merged 7 commits into from Sep 10, 2019

Conversation

@jeremeguenther
Copy link
Collaborator

commented Sep 7, 2019

The features and upgrades have all been split into their own commits for easier review.
New features:
VoidProcTransaction
Extended property
New Base classes

upgrades:
formatting
connectionstring in error
param sql string builder

Formatting only
These changes are only formatting changes, no functionality changes.

Newlines, removing trailing spaces, and replacing tabs with spaces.
VoidProcTransaction
Added feature allowing users to disable the default feature that wraps all custom sprocs that return void in a transaction.

By default this feature is left turned on.

One small piece of this feature ended up in the formatting commit in file ComponentDataAccess.cst lines 1527 and 1582, most of it is in this commit.
ConnectionString in error
Add the connection string information without credentials to the custom error that gets thrown when a sql call blows up.
Extended property feature
For the MS-SQL data access layer, add the ability to create custom Extended properties in the database on database columns (not tables).  There is a setting allowing the custom property prefix to be customized.  These custom properties are then written to each column enum value and can be used in code.

This provides a way to specify additional meta information in the database as the column level.
Param sql string builder ' bug
Fixes a bug in the parameterized sql builder where tick marks get double encoded.  Also includes a couple other minor fixes to the sql string builder.
New base classes
Until now, All table entities had a base class they inherrited from.
This changes gives all View entities their own base class, and Also creates a single overall base class for all netTiers table and view entities.

This allows methods to pass around objects at the view, table, or netTiers level.
New Column attribute helper methods
New helper method used to get the custom attributes off of column enum entities.  Is an addition to the custom column attributes in sql feature.
@jeremeguenther

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 7, 2019

All of these changes have been running in two different production code bases of mine for over a week now after two week of QA.

@niemyjski
Copy link
Contributor

left a comment

LGTM :) Thanks

the procedure template, the rowobject template, and the rowcollection template on
the same table. You can also optionally use the main script which will run them all
for you.
Written By:

This comment has been minimized.

Copy link
@niemyjski

niemyjski Sep 8, 2019

Contributor

Would be nice if future whitespace changes were just committed to master and left out of pr's :) With that said thanks for fixing the whitespace :)

@jeremeguenther jeremeguenther merged commit 8557258 into netTiers:master Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.