Large pull request including 3 new features and three upgrades #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 6, 2019 17:02
These changes are only formatting changes, no functionality changes. Newlines, removing trailing spaces, and replacing tabs with spaces.
Added feature allowing users to disable the default feature that wraps all custom sprocs that return void in a transaction. By default this feature is left turned on. One small piece of this feature ended up in the formatting commit in file ComponentDataAccess.cst lines 1527 and 1582, most of it is in this commit.
Add the connection string information without credentials to the custom error that gets thrown when a sql call blows up.
For the MS-SQL data access layer, add the ability to create custom Extended properties in the database on database columns (not tables). There is a setting allowing the custom property prefix to be customized. These custom properties are then written to each column enum value and can be used in code. This provides a way to specify additional meta information in the database as the column level.
Fixes a bug in the parameterized sql builder where tick marks get double encoded. Also includes a couple other minor fixes to the sql string builder.
Until now, All table entities had a base class they inherrited from. This changes gives all View entities their own base class, and Also creates a single overall base class for all netTiers table and view entities. This allows methods to pass around objects at the view, table, or netTiers level.
New helper method used to get the custom attributes off of column enum entities. Is an addition to the custom column attributes in sql feature.
|
All of these changes have been running in two different production code bases of mine for over a week now after two week of QA. |
niemyjski
approved these changes
Sep 8, 2019
| the procedure template, the rowobject template, and the rowcollection template on | ||
| the same table. You can also optionally use the main script which will run them all | ||
| for you. | ||
| Written By: |
There was a problem hiding this comment.
Would be nice if future whitespace changes were just committed to master and left out of pr's :) With that said thanks for fixing the whitespace :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The features and upgrades have all been split into their own commits for easier review.
New features:
VoidProcTransaction
Extended property
New Base classes
upgrades:
formatting
connectionstring in error
param sql string builder