Removing legacy/nonstandard validations for MAC addresses #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, MAC validations accept non-standard MACs that drop leading digits. I cannot find documentation from any mentioned manufacturer that currently accepts these non-standard MACs. Any non-standard MAC should be validated by a separate routine, or we're not validating MAC addresses. References ========== Cisco: https://www.ciscopress.com/articles/article.asp?p=3089352&seqNum=5 "When using hexadecimal, leading zeros are always displayed to complete the 8-bit representation. For example, in Figure 7-6, the binary value 0000 1010 is shown to be 0A in hexadecimal." Postgres: https://www.postgresql.org/docs/9.1/datatype-net-types.html All examples are 12 hex digits IETF: I can't find a single RFC dropping leading zeroes. IEEE: I don't have access to the actual EUI-48 spec, but I see nothing indicating that anyone drops the zeroes.
|
Bug 1949632 - MAC address validation passes on invalid MAC addresses (dropped hex digits) - BZ I filed for python-neutron-lib, since this causes issues downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MAC validations accept non-standard MACs that drop
leading digits. I cannot find documentation from any mentioned
manufacturer that currently accepts these non-standard MACs.
Any non-standard MAC should be validated by a separate routine, or
we're not validating MAC addresses.
References
Cisco:
https://www.ciscopress.com/articles/article.asp?p=3089352&seqNum=5
"When using hexadecimal, leading zeros are always displayed to
complete the 8-bit representation. For example, in Figure 7-6,
the binary value 0000 1010 is shown to be 0A in hexadecimal."
Postgres:
https://www.postgresql.org/docs/9.1/datatype-net-types.html
All examples are 12 hex digits
IETF:
I can't find a single RFC dropping leading zeroes.
IEEE:
I don't have access to the actual EUI-48 spec, but I see nothing
indicating that anyone drops the zeroes.