feat/add-android-tv-support #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pappz
reviewed
Nov 17, 2025
Contributor
Author
|
doromaraujo
reviewed
Nov 17, 2025
doromaraujo
reviewed
Nov 17, 2025
shuuri-labs
force-pushed
the
feat/add-android-tv-support
branch
3 times, most recently
from
060014b to
2b85832
Compare
Collaborator
|
@shuuri-labs Looks like the close button in the peers/networks view is not selectable. |
pappz
reviewed
Nov 21, 2025
| android:textSize="18sp" | ||
| android:textStyle="bold" | ||
| android:textColor="@android:color/black" | ||
| android:text="Device Code: XXXX-XXXX" |
Collaborator
There was a problem hiding this comment.
Please move the texts to the strings.xml
Collaborator
|
The peers view is broken on all types of screens. The hamburger menu has been hidden, and it does not cover the view at the bottom of the screen |
pappz
reviewed
Nov 21, 2025
|
|
||
| // Pass TV flag to fragments | ||
| Bundle args = new Bundle(); | ||
| args.putBoolean("isRunningOnTV", isRunningOnTV); |
Collaborator
There was a problem hiding this comment.
Use constant instead of a string
Collaborator
|
If I touch the new 'Close' button, the service gets stuck in the 'Connecting' state, and I can never retry. |
Add android TV support with the following changes: - Implement new URLOpener interface with updated open method that accepts UserCode - Add logic to MainActivity.java to detect Android TV, adjust UI and SSO flow accordingly - Add QRCodeDialog.java to handle QR code/user code display logic - Updated relevant layout xml files - Add TV banner icon
shuuri-labs
force-pushed
the
feat/add-android-tv-support
branch
4 times, most recently
from
881bc63 to
f9aa4a0
Compare
- qr code dialog now auto-dismisses when connection successful, or reports failure to mainactivity when not successful - general cleanup
shuuri-labs
force-pushed
the
feat/add-android-tv-support
branch
from
f9aa4a0 to
2f63a45
Compare
doromaraujo
approved these changes
Nov 25, 2025
pappz
added a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add android TV support with the following changes: