restart go engine on network change #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From HashSet to ConcurrentHashMap's KeySet, which is thread-safe.
When subscribing to ConcreteNetworkAvailabilityListener
The availableNetworkTypes HashMap is accessed from network callback threads without synchronization
Restart runnable is used as a debouncing mechanism to prevent concurrent restarts Timeout callback is to reset the isRestartInProgress flag's value if the engine takes too long to restart
pappz
reviewed
Nov 12, 2025
Collaborator
There was a problem hiding this comment.
Can we run from CI the Android test?
pappz
reviewed
Nov 12, 2025
| } | ||
|
|
||
| @Override | ||
| public void onNetworkAvailable(@Constants.NetworkType int networkType) { |
Collaborator
There was a problem hiding this comment.
Consider another transport types. It would be important on Android TV or IoT devices.
TRANSPORT_ETHERNET, TRANSPORT_SATELLITE, etc...
Collaborator
Author
There was a problem hiding this comment.
We'll skip those for now as discussed.
pappz
reviewed
Nov 12, 2025
Now it disposes of network listener components before stopping engineRunner
Add testing steps for CI
pappz
previously approved these changes
Nov 18, 2025
pappz
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism that tracks available network capabilities and resets the go engine when the connection changes.
Scenarios:
WiFi is lost -> Cellular is available
Cellular is available -> WiFi is available