feat(acl): add rules for ACL

[gigovich]

No description provided.

[braginini]

Any particular reason why we return a map not a list of rules?
All other endpoints return [peers] or [users].
This one returns a map.

{
  "ca2im93lo1hs0mlug03g": {
    "ID": "ca2im93lo1hs0mlug03g",
    "Name": "Default",
    "Source": [
      "ca2im93lo1hs0mlug030"
    ],
    "Destination": [
      "ca2im93lo1hs0mlug030"
    ],
    "Flow": 0
  }
}

I propose returning rules in such a structure:

[
   {
      "ID":"ca2im93lo1hs0mlug03g",
      "Name":"Default",
      "Source":[
         "ca2im93lo1hs0mlug030"
      ],
      "Destination":[
         "ca2im93lo1hs0mlug030"
      ],
      "Flow":0
   }
]

It will be much easier to handle on the UI side because all the Table components are built to handle an array.
Also this way we are more consistent with our API

P.S. The same applies to the /api/groups endpoint

[braginini]

I also think that returning account.Rules is a bit dangerous because it is our internal structure.
It might be that we rename fields internally or would like to change how fields are returned.
I'd suggest creating a RuleResponse struct to return (see PeerRersponse for example). Let's be consistent here as well.

P.S. The same applies to the /api/groups endpoint

[braginini]

See proposed changes below

[braginini]

Suggested change

	writeJSONObject(w, account.Rules)
	var respBody []*RuleResponse
	for _, rule := range account.Rules {
	respBody = append(respBody, toRuleResponse(rule))
	}
	writeJSONObject(w, respBody)

[braginini]

Suggested change

	type RuleResponse struct {
	ID string
	Name string
	Sources []string
	Destinations []string
	Flow server.TrafficFlowType
	Enabled bool
	}

[braginini]

Suggested change

	}
	}
	func toRuleResponse(rule *server.Rule) *RuleResponse {
	return &RuleResponse{
	Name: rule.Name,
	ID: rule.ID,
	Destinations: rule.Destination,
	Sources: rule.Source,
	Flow: rule.Flow,
	Enabled: true,
	}
	}

[braginini]

proposed changes applied

See
#306 (comment)

[braginini]

Another point.

We return Source and Destination groups IDs but no Name.
In the UI we will need to show the Name of the group in Source and Destination.
I suggest combining it already on the server-side. Any thoughts?

This:

[
  {
    "ID": "ca2im93lo1hs0mlug03g",
    "Name": "Default",
    "Source": [
      "ca2im93lo1hs0mlug030"
    ],
    "Destination": [
      "ca2im93lo1hs0mlug030"
    ],
    "Flow": 0
  }
]

Replace With this

[
  {
    "ID": "ca2im93lo1hs0mlug03g",
    "Name": "Default",
    "Source": [
     { "ca2im93lo1hs0mlug030", "Name": "All" }
    ],
    "Destination": [
      { "ca2im93lo1hs0mlug030", "Name": "All" }
    ],
    "Flow": 0
  }
]

[braginini]

It seems like a peer is not removed from the groups when peer is deleted from the account

management Server fails with NPE when:

1. add 2 peers
2. remove 1 peer
3. add 1 peer <-NPE on am.GetNetworkMap in

		for _, pid := range g.Peers {
			peer := account.Peers[pid]
			// exclude original peer
			if peer.Key != peerKey {
				res = append(res, peer.Copy())
			}
		}
	}