From 2a7d344fb30a7a728222e73b9397760e1d101ed0 Mon Sep 17 00:00:00 2001
From: Leonardo Parente <leonardo.parente@encora.com>
Date: Fri, 24 Mar 2023 14:29:09 -0400
Subject: [PATCH] Remove not used histogram metric group from dns v2

---
 src/handlers/dns/v2/DnsStreamHandler.h       | 2 --
 src/handlers/dns/v2/tests/test_dns_layer.cpp | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/handlers/dns/v2/DnsStreamHandler.h b/src/handlers/dns/v2/DnsStreamHandler.h
index 63ff48eeb..54cb5dd51 100644
--- a/src/handlers/dns/v2/DnsStreamHandler.h
+++ b/src/handlers/dns/v2/DnsStreamHandler.h
@@ -42,7 +42,6 @@ enum DnsMetrics : visor::MetricGroupIntType {
     Cardinality,
     Counters,
     Quantiles,
-    Histograms,
     TopEcs,
     TopQtypes,
     TopRcodes,
@@ -567,7 +566,6 @@ class DnsStreamHandler final : public visor::StreamMetricsHandler<DnsMetricsMana
         {"cardinality", group::DnsMetrics::Cardinality},
         {"counters", group::DnsMetrics::Counters},
         {"quantiles", group::DnsMetrics::Quantiles},
-        {"histograms", group::DnsMetrics::Histograms},
         {"top_ecs", group::DnsMetrics::TopEcs},
         {"top_qtypes", group::DnsMetrics::TopQtypes},
         {"top_rcodes", group::DnsMetrics::TopRcodes},
diff --git a/src/handlers/dns/v2/tests/test_dns_layer.cpp b/src/handlers/dns/v2/tests/test_dns_layer.cpp
index 71ae014d2..d80ee758e 100644
--- a/src/handlers/dns/v2/tests/test_dns_layer.cpp
+++ b/src/handlers/dns/v2/tests/test_dns_layer.cpp
@@ -917,13 +917,13 @@ TEST_CASE("DNS groups", "[pcap][dns]")
     SECTION("disable invalid dns group")
     {
         dns_handler.config_set<visor::Configurable::StringList>("disable", {"top_qnames", "dns_top_wired"});
-        REQUIRE_THROWS_WITH(dns_handler.start(), "dns_top_wired is an invalid/unsupported metric group. The valid groups are: all, cardinality, counters, histograms, quantiles, top_ecs, top_ports, top_qnames, top_qtypes, top_rcodes, top_size, xact_times");
+        REQUIRE_THROWS_WITH(dns_handler.start(), "dns_top_wired is an invalid/unsupported metric group. The valid groups are: all, cardinality, counters, quantiles, top_ecs, top_ports, top_qnames, top_qtypes, top_rcodes, top_size, xact_times");
     }
 
     SECTION("enable invalid dns group")
     {
         dns_handler.config_set<visor::Configurable::StringList>("enable", {"top_qnames", "dns_top_wired"});
-        REQUIRE_THROWS_WITH(dns_handler.start(), "dns_top_wired is an invalid/unsupported metric group. The valid groups are: all, cardinality, counters, histograms, quantiles, top_ecs, top_ports, top_qnames, top_qtypes, top_rcodes, top_size, xact_times");
+        REQUIRE_THROWS_WITH(dns_handler.start(), "dns_top_wired is an invalid/unsupported metric group. The valid groups are: all, cardinality, counters, quantiles, top_ecs, top_ports, top_qnames, top_qtypes, top_rcodes, top_size, xact_times");
     }
 }