Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

WMI Process (APPS) #953

Merged
merged 13 commits into from
Oct 29, 2022
Merged

WMI Process (APPS) #953

merged 13 commits into from
Oct 29, 2022

Conversation

thiagoftsm
Copy link
Contributor

This PR is bringing process monitoring for Microsoft like we have for Linux/BSD/Mac processes.

We are bringing metrics analogous o metrics we are collecting for Linux/BSD/Mac environments.

1
2
3

@ilyam8
Copy link
Member

ilyam8 commented Oct 29, 2022

Hi. Let's name them process metrics, not apps. I don't think we try to copy Netdata metric names (which will be renamed anyway).

ok, I'll do it in the follow-up PR.

@ilyam8 ilyam8 merged commit 0dd721a into netdata:master Oct 29, 2022
@thiagoftsm
Copy link
Contributor Author

Hi. Let's name them process metrics, not apps. I don't think we try to copy Netdata metric names (which will be renamed anyway).

I confess I did not like the idea to have two names for the same stored objects, probably this creates confusions for users (ping @shyamvalsan and @cakrit ), but I do not have objections to use process

@thiagoftsm thiagoftsm deleted the wmi_process branch October 30, 2022 13:44
@ilyam8
Copy link
Member

ilyam8 commented Oct 30, 2022

What "the same"? I am not aware that Netdata collects per-process metrics. Not sure I understand the confusion part too.

@thiagoftsm
Copy link
Contributor Author

What "the same"? I am not aware that Netdata collects per-process metrics. Not sure I understand the confusion part too.

Process and Apps are different names for the same objects, software running on computer. In my understanding we should use only one word to name them independent of the operate system netdata is running.

@ilyam8
Copy link
Member

ilyam8 commented Oct 30, 2022

Ok, thanks for the explanation! apps.plugin doesn't collect (expose as charts) per-process metrics, do you know that?

@thiagoftsm
Copy link
Contributor Author

Ok, thanks for the explanation! apps.plugin doesn't collect (expose as charts) per-process metrics, do you know that?

Yes, but we organize metrics per apps groups and one day these windows metrics could be per apps groups too.

The fact that we do not collect per apps does not mean that we should do this. It is completely possible for users to convert apps group in application.

@ilyam8
Copy link
Member

ilyam8 commented Oct 30, 2022

could be per apps groups too

Could be or could not be. Just answering to "the same stored objects" - I don't see that processes == (custom) process groups. In addition, I don't understand why you are actively insisting on some parity to Linux metrics names (the ones we have now in Netdata will be renamed, 100% of them will change their names).

But in general, I understand your point, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants