Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Fix RBAC. ClusterRoleBinding installed SeviceAccount only from name… #11

Merged
merged 2 commits into from Apr 3, 2019

Conversation

@varyumin
Copy link
Collaborator

varyumin commented Apr 2, 2019

  • Fix RBAC. ClusterRoleBinding can use SeviceAccount only from namespace default. If you installed in another namespace ("not default") then ServiceAccount and ClusterRoleBinding didn't work
  • Feature RBAC. You can pick between "turn on" (helm ... -set rbac.create=true) or "turn off" (helm ... -set rbac.create=false) RBAC.
  • Feature RBAC. You can create serviceAccount or use your existing serviceAccount.
  • I have changed liveness and readiness probes on /api/v1/info
  • Added myself to Chart.yaml (if you don't mind @cakrit )
…space default. If you installed in another namespace ("not default") then ServiceAccount and ClusterRoleBinding didn't work

* Feature RBAC. You can pick between "turn on" (helm ... -set rbac.create=true) or "turn off" (helm ... -set rbac.create=false) RBAC.
* Feature RBAC. You can create serviceAccount or use your existing serviceAccount.
* I have changed liveness and readiness probes on /api/v1/info
* Added me to Chart.yaml (if you don't mind )
Copy link
Contributor

cakrit left a comment

Of course I don't mind! You're the man!
Please update the README as well. I will try it today (though it's a hectic day).

@varyumin

This comment has been minimized.

Copy link
Collaborator Author

varyumin commented Apr 2, 2019

Ok. I will update README.md

@cakrit

This comment has been minimized.

Copy link
Contributor

cakrit commented Apr 2, 2019

I also mentioned you in netdata/netdata#5764.
The probes just look for an HTTP 200 code, right? Just so I know if we have any dependency on getting that right. e.g. can they look for a specific answer in that response? It's so I know how to design it, because I'll put in some more logic on when and how netdata responds.

@cakrit

This comment has been minimized.

Copy link
Contributor

cakrit commented Apr 2, 2019

Ok, I upgraded and saw the slave containers getting restarted serially. It takes ~1 minute for the last of my 3 slaves to get upgraded, but I suppose this is normal. I'll approve as soon as you update the README.

I noticed another problem while testing, I'll create a new issue for that.

…space default. If you installed in another namespace ("not default") then ServiceAccount and ClusterRoleBinding didn't work

* Feature RBAC. You can pick between "turn on" (helm ... -set rbac.create=true) or "turn off" (helm ... -set rbac.create=false) RBAC.
* Feature RBAC. You can create serviceAccount or use your existing serviceAccount.
* I have changed liveness and readiness probes on /api/v1/info
* Added me to Chart.yaml (if you don't mind )
@varyumin

This comment has been minimized.

Copy link
Collaborator Author

varyumin commented Apr 3, 2019

The probes just look for an HTTP 200 code, right?

If we used httpGet probes, Yes it will be 200 OK, but we can use another method. For example tcpSocket or another custom script (https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#define-a-liveness-http-request)
Maybe do you know which special port opens the slave netdata. And we can use probes kind tcpSocket

@varyumin

This comment has been minimized.

Copy link
Collaborator Author

varyumin commented Apr 3, 2019

I have updated README.md

@varyumin varyumin requested a review from cakrit Apr 3, 2019
@cakrit
cakrit approved these changes Apr 3, 2019
@cakrit

This comment has been minimized.

Copy link
Contributor

cakrit commented Apr 3, 2019

Thanks. Merge whenever you want.

@varyumin varyumin merged commit 1d0fda3 into master Apr 3, 2019
1 check passed
1 check passed
WIP Ready for review
Details
@cakrit cakrit deleted the rbacAndProbs branch Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.