New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater script no longer seems to be working after a recent update #5228

Closed
jorisvervuurt opened this Issue Jan 20, 2019 · 9 comments

Comments

Projects
None yet
5 participants
@jorisvervuurt
Copy link
Contributor

jorisvervuurt commented Jan 20, 2019

I just tried to manually install an update of Netdata, but I noticed the /usr/src/netdata.git/netdata-updater.sh script immediately exits without actually doing anything.

I’ve tried re-running bash <(curl -Ss https://my-netdata.io/kickstart.sh), which starts fine but exits immediately after it runs the ./netdata-updater.sh -f command. It shows ‘OK’ though...

I’m running the latest Ubuntu Desktop 18.04 LTS (Bionic Beaver).

@jpeizer

This comment has been minimized.

Copy link

jpeizer commented Jan 20, 2019

I am having the same issue. After looking into it, it appears at some point the updater file was emptied, and now reads 0 byte size.

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Jan 20, 2019

We changed how updater works. It should be a file located in your daily cron directory and run by cron (usually /etc/cron.daily/netdata-updater). Running ./netdata-updater.sh -f is no longer a recommended option.

Change was needed to remove dependency on having source code directory on hosts and decouple packaging from development. Right now updater is supposed to fetch tarballs from GCS, put them in temporary directory and rerun installer from there.

Sorry for inconvenience but this is a necessary step to have a gating jobs so we won't break user environments like it happened a couple weeks ago and like it seems that is happening now.

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Jan 20, 2019

If you can, please temporarily use https://raw.githubusercontent.com/netdata/netdata/master/packaging/installer/kickstart.sh instead of https://my-netdata.io/kickstart.sh.

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Jan 20, 2019

https://my-netdata.io/kickstart.sh should be correct now. Could you retry your installation?

@paulfantom paulfantom added this to the v1.12 milestone Jan 20, 2019

paulfantom added a commit to paulfantom/netdata that referenced this issue Jan 20, 2019

paulfantom added a commit that referenced this issue Jan 20, 2019

Fix nightly builds and cron autoupdater (#5232)
* add gating before using polyverse

* workaround for installations which doesn't use newer installer

* fix #5225; #5229; #5228; #5208
@koebi001

This comment has been minimized.

Copy link

koebi001 commented Jan 21, 2019

This is on Debian stretch.
On all my hosts /etc/cron.daily/netdata-updater is a symbolic link to /usr/src/netdata.git/netdata-updater.sh which now is empty. and therefore produces lots of emails from cron.
A new unattended installation using the https://my-netdata.io/kickstart.sh is not working:

$ service netdata stop && rm -rf /usr/src/netdata.git && rm -rf /etc/netdata && rm -f /etc/cron.daily/netdata-updater
$ /bin/bash -c "bash <(curl -Ss https://my-netdata.io/kickstart.sh) --dont-wait -u"
System            : Linux
Operating System  : GNU/Linux
Machine           : x86_64
BASH major version: 
 --- Downloading script to detect required packages... --- 
$'[\E[2m/tmp/netdata-kickstart-q2u1Zr\E(B\E[0m]# \E[1m\E[33m' wget -O - https://raw.githubusercontent.com/netdata/netdata-demo-site/master/install-required-packages.sh $'\E(B\E[0m\\n' --2019-01-21 13:25:18--  https://raw.githubusercontent.com/netdata/netdata-demo-site/master/install-required-packages.sh
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 151.101.112.133
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|151.101.112.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 41978 (41K) [text/plain]
Saving to: ‘STDOUT’

-                                              100%[===================================================================================================>]  40.99K  --.-KB/s    in 0.03s   

2019-01-21 13:25:18 (1.24 MB/s) - written to stdout [41978/41978]

 OK  wget -O - https://raw.githubusercontent.com/netdata/netdata-demo-site/master/install-required-packages.sh 

 --- Running downloaded script to detect required packages... --- 
$'[\E[2m/tmp/netdata-kickstart-q2u1Zr\E(B\E[0m]# \E[1m\E[33m' /bin/bash /tmp/netdata-kickstart-q2u1Zr/install-required-packages.sh --dont-wait --non-interactive netdata $'\E(B\E[0m\\n' Loading /etc/os-release ...

/etc/os-release information:
NAME            : Debian GNU/Linux
VERSION         : 9 (stretch)
ID              : debian
ID_LIKE         : 
VERSION_ID      : 9

We detected these:
Distribution    : debian
Version         : 9
Codename        : 9 (stretch)
Package Manager : install_apt_get
Packages Tree   : debian
Detection Method: /etc/os-release
Default Python v: 2 

 > Checking if package 'autoconf-archive' is installed...
 > Checking if package 'zlib1g-dev' is installed...
 > Checking if package 'uuid-dev' is installed...
 > Checking if package 'libmnl-dev' is installed...
 > Checking if package 'python-yaml' is installed...
 > Checking if package 'python-pymongo' is installed...

All required packages are already installed. Now proceed to the next step.

 OK  /bin/bash /tmp/netdata-kickstart-q2u1Zr/install-required-packages.sh --dont-wait --non-interactive netdata 

 WARNING  It failed to install all the required packages, but installation might still be possible. 

 ABORTED  Stopping due to non-interactive mode. Fix the issue or retry installation in an interactive mode. 
@cakrit

This comment has been minimized.

Copy link
Contributor

cakrit commented Jan 21, 2019

The last comment is a duplicate of #5240.
PR #5241 should get this working.

@koebi001

This comment has been minimized.

Copy link

koebi001 commented Jan 21, 2019

If I run kickstart.sh now I get the following:

/bin/bash -c "bash <(curl -Ss https://my-netdata.io/kickstart.sh) --dont-wait -u"
 --- Re-installing netdata... --- 
$'[\E[2m/root\E(B\E[0m]# \E[1m\E[33m' '' /etc/cron.daily/netdata-updater -f $'\E(B\E[0m\\n' /dev/fd/63: line 88: : command not found
 FAILED   /etc/cron.daily/netdata-updater -f 

 ABORTED  Failed to forcefully update netdata 

After deleting the link /etc/cron.daily/netdata-updater kickstart.sh repaired the setup

$ rm -f /etc/cron.daily/netdata-updater
$ /bin/bash -c "bash <(curl -Ss https://my-netdata.io/kickstart.sh) --dont-wait -u"
@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Jan 28, 2019

Should be fixed by #5276

@paulfantom

This comment has been minimized.

Copy link
Member

paulfantom commented Jan 30, 2019

All problems reported in this issue should be already fixed. We are now waiting for propagation of kickstart.sh script to be available under https://my-netdata.io/kickstart.sh (new version has following md5sum: f16d433f3fc86264fa2e05808369c54b).

Thank you for your patience. If something still doesn't work please reopen this issue.

@paulfantom paulfantom closed this Jan 30, 2019

EnzoAkira added a commit to EnzoAkira/netdata that referenced this issue Feb 18, 2019

Fix nightly builds and cron autoupdater (netdata#5232)
* add gating before using polyverse

* workaround for installations which doesn't use newer installer

* fix netdata#5225; netdata#5229; netdata#5228; netdata#5208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment