New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ML-related charts #12574
Update ML-related charts #12574
Conversation
Use the hostname in each chart's name, and the machine GUID in each chart's id.
@vkalintiris , please, rebase your PR to fix the conflict. @andrewm4894 I tested the PR and I think it is reaching the goal you propose in initial discussion, after the rebase, can you take a look to confirm? I am waiting for rebase and confirmation to retest and approve. Thank you guys! |
testing this today. will update when i have nodes created and available in here: https://staging.netdata.cloud/spaces/mlstress/rooms/general/overview @k-manolis is helping me adapt the mlstress stuff to just run off this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is working as expected in this room https://staging.netdata.cloud/spaces/mlstress/rooms/general/overview
anomaly advisor working for all node instances even though the parent is running the ml for all thress children.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that @andrewm4894 confirmed my initial impression while I was testing, LGTM!
@vkalintiris one question. I have the following set up:
I don't see any anomaly detection charts on I also don't see child0 on anomaly advisor either, this may be perhaps because only the parent is claimed to this room, ill need to double check. So i think this all is working apart from that we do still want to stream the anomaly detection charts such that i would see the anomaly detection charts for fyi you can see all this in here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my last comment, just wanted to undo my approve.
@andrewm4894 see #12477 (reply in thread) IIRC, @ktsaou did not want Instead of modifying the IOW, you can explicitly enable streaming of anomaly detection charts by setting the aforementioned option to |
@vkalintiris cool, I'll update my config to test this. Will report back here once it's all trained. |
@vkalintiris yep - when i add So we are all good here. I feel like the default of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@andrewm4894 Yep I think the name after |
@juacker yep i think that makes sense. |
I also like it set to yes by default |
Summary
Test Plan
Inspect parent/child dashboards with
build_external/scenarios/parent-child
with ML enabled and with/without streaming of ML charts.
Additional Information
Resolves #12549