fix(cgroups.plugin): do not add network devices if cgroup proc is in the host net ns #12788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
detect_veth_interfaces() works correctly only when the cgroup proc (cgroup.procs) is not in the host network namespace.
The bug was discovered when we installed Netdata on a Proxmox host with several VMs.
The end result is adding all double-linked host interfaces to the last discovered VM cgroup.
Screenshot
Screenshot when the patch applied
Test Plan
Check VM cgroups network interfaces.
Additional Information
For users: How does this change affect me?