New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert health to run in a single thread #14244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrZammler
requested review from
thiagoftsm,
vkalintiris,
stelfrag and
underhood
as code owners
January 12, 2023 13:49
stelfrag
reviewed
Jan 13, 2023
stelfrag
reviewed
Jan 13, 2023
stelfrag
reviewed
Jan 13, 2023
stelfrag
reviewed
Jan 13, 2023
stelfrag
reviewed
Jan 17, 2023
stelfrag
approved these changes
Jan 17, 2023
thiagoftsm
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is working as expected for parent and children. I also have my alerts on cloud and telegram, LGTM!
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts health to run in a single thread for all hosts. It still retains the health initialization in the health thread as so to not delay host creation.
Test Plan
Will be tested that it performs as it should in regards also to the cloud.
Additional Information
For users: How does this change affect me?