Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert health to run in a single thread #14244

Merged
merged 6 commits into from Jan 18, 2023

Conversation

MrZammler
Copy link
Contributor

Summary

This PR reverts health to run in a single thread for all hosts. It still retains the health initialization in the health thread as so to not delay host creation.

Test Plan

Will be tested that it performs as it should in regards also to the cloud.

Additional Information
For users: How does this change affect me?

database/rrd.h Outdated Show resolved Hide resolved
health/health.c Outdated Show resolved Hide resolved
health/health.c Outdated Show resolved Hide resolved
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working as expected for parent and children. I also have my alerts on cloud and telegram, LGTM!

@MrZammler
Copy link
Contributor Author

Thank you!

@MrZammler MrZammler merged commit 3d5f9e6 into netdata:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants