Change how the ip address and port are logged in socket.c #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ip address and port are currently logged in two formats: "%s:%s" and "%s port %s". Not only is this inconsistent, but when the first of the above mentioned formatting is used and an ipv6 address is logged it is hard to read it. This patch removes the "%s:%s" occurrences. This fixes netdata#5067.
ktsaou
approved these changes
Jan 14, 2019
vlvkobal
approved these changes
Jan 14, 2019
kiku-jw
pushed a commit
to kiku-jw/netdata
that referenced
this pull request
Mar 4, 2019
The ip address and port are currently logged in two formats: "%s:%s" and "%s port %s". Not only is this inconsistent, but when the first of the above mentioned formatting is used and an ipv6 address is logged it is hard to read it. This patch removes the "%s:%s" occurrences. This fixes netdata#5067.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ip address and port are currently logged in two formats: "%s:%s" and "%s port %s".
Not only is this inconsistent, but when the first of the above mentioned formatting is used and an ipv6 address is logged it is hard to read it.
This patch removes the "%s:%s" occurrences.
Component Name
netdata core
This fixes #5067