Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified cgroup support #5407

Merged
merged 9 commits into from Apr 9, 2019

Conversation

Projects
None yet
5 participants
@skrzyp1
Copy link
Contributor

commented Feb 17, 2019

Summary

Fixes #3750

Component Name
Additional Information

@skrzyp1 skrzyp1 requested review from cakrit, ktsaou and vlvkobal as code owners Feb 17, 2019

@CLAassistant

This comment has been minimized.

Copy link

commented Feb 17, 2019

CLA assistant check
All committers have signed the CLA.

@cakrit

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

I edited the first comment to add the reference to the issue.

@skrzyp1 skrzyp1 changed the title WiP unified cgroup support unified cgroup support Mar 29, 2019

@netdata netdata deleted a comment from netdatabot Apr 1, 2019

@netdata netdata deleted a comment from netdatabot Apr 1, 2019

@vlvkobal
Copy link
Member

left a comment

Tested it and read line by line.
@skrzyp1 don't you want to implement CPU limits? As I see, cgroup v2 provides cpu.max.

@skrzyp1

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

@vlvkobal I can implement them too, just wanted to have this part merged so there will be no merge conflicts when other people edit. I can do that as a separate issue is that ok?

Show resolved Hide resolved collectors/cgroups.plugin/sys_fs_cgroup.c Outdated
@vlvkobal

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

I can do that as a separate issue is that ok?

It is OK. But please update the documentation in this PR.

@skrzyp1

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@cakrit I removed unused variable. @vlvkobal I added info to docs. Is everything ok now?

@cakrit

cakrit approved these changes Apr 9, 2019

@vlvkobal vlvkobal merged commit 6724b63 into netdata:master Apr 9, 2019

9 of 12 checks passed

Header rules - netdata No header rules processed
Details
Pages changed - netdata 8 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.