Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry delete should allow deleting the host we are looking at #5537

Merged
merged 2 commits into from Mar 4, 2019

Conversation

@cakrit
Copy link
Contributor

cakrit commented Mar 2, 2019

Summary

Fixes #5518

Component Name

registry

Additional Information

Remove check on whether a server delete request comes from the same server we are looking at

@cakrit cakrit requested review from gmosx and ktsaou as code owners Mar 2, 2019
@gmosx gmosx self-requested a review Mar 3, 2019
@gmosx
gmosx approved these changes Mar 3, 2019
Copy link
Contributor

gmosx left a comment

The code does what the description says.

@cakrit cakrit merged commit 8a71932 into netdata:master Mar 4, 2019
12 checks passed
12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
Kiku-Reise added a commit to Kiku-Reise/netdata that referenced this pull request Mar 4, 2019
…data#5537)

* Remove check on whether a server delete request comes from the same server we are looking at
@cakrit cakrit deleted the cakrit:registry_delete branch Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.