Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send zeroes for empty groups #5540

Merged
merged 1 commit into from Mar 5, 2019

Conversation

@vlvkobal
Copy link
Member

vlvkobal commented Mar 3, 2019

Summary

Don't send zeroes when all processes from a group have been exited.

Fixes #5514
Fixes #5547

Component Name

apps.plugin

@vlvkobal vlvkobal requested review from cakrit and ktsaou as code owners Mar 3, 2019
@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Mar 3, 2019

i don't think we need obsolete, don't send zeros is enough.

@vlvkobal

This comment has been minimized.

Copy link
Member Author

vlvkobal commented Mar 4, 2019

I discussed the PR with @ilyam8. He thinks that obsoleting dimensions is the last resort we should use in case we have tons of dimensions. In apps.plugin there is a finite number of groups, so we can afford to keep data in the database. @cakrit, @ktsaou, what do you think?

@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Mar 4, 2019

I see no reason to obsolete dimensions (mark as obsolete => delete from database), it makes no sense to me

@cakrit

This comment has been minimized.

Copy link
Contributor

cakrit commented Mar 4, 2019

Since it's a finite, well known set, I think @ilyam8 is correct.

@vlvkobal vlvkobal force-pushed the vlvkobal:apps-zeroes branch from d1d67e3 to 3b4466b Mar 5, 2019
@vlvkobal vlvkobal changed the title Obsolete dimensions for empty groups Don't send zeroes for empty groups Mar 5, 2019
@vlvkobal

This comment has been minimized.

Copy link
Member Author

vlvkobal commented Mar 5, 2019

I removed obsoleting dimensions. Thus, only sending zeroes is suppressed.

@ilyam8
ilyam8 approved these changes Mar 5, 2019
@cakrit
cakrit approved these changes Mar 5, 2019
@vlvkobal vlvkobal merged commit 3e6a790 into netdata:master Mar 5, 2019
12 checks passed
12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
@vlvkobal vlvkobal deleted the vlvkobal:apps-zeroes branch Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.